[Mesa-dev] [PATCH 3/4] intel/batch_decoder: Fix dynamic state printing

Jason Ekstrand jason at jlekstrand.net
Fri Aug 24 21:40:58 UTC 2018


Instead of printing addresses like everyone else, we were accidentally
printing the offset from state base address.  Also, state_map is a void
pointer so we were incrementing in bytes instead of dwords and every
state other than the first was wrong.
---
 src/intel/common/gen_batch_decoder.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c
index f93f4df0066..a57bd93e0f0 100644
--- a/src/intel/common/gen_batch_decoder.c
+++ b/src/intel/common/gen_batch_decoder.c
@@ -665,10 +665,10 @@ decode_dynamic_state_pointers(struct gen_batch_decode_ctx *ctx,
 
    for (int i = 0; i < count; i++) {
       fprintf(ctx->fp, "%s %d\n", struct_type, i);
-      ctx_print_group(ctx, state, state_offset, state_map);
+      ctx_print_group(ctx, state, state_addr, state_map);
 
       state_addr += state->dw_length * 4;
-      state_map += state->dw_length;
+      state_map += state->dw_length * 4;
    }
 }
 
-- 
2.17.1



More information about the mesa-dev mailing list