[Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

[Samuel Iglesias Gonsálvez]

On Tuesday, August 28, 2018 2:02:07 PM CEST Samuel Iglesias Gonsálvez wrote:
> I'll do it later today.

Done!

Sam

> 
> Thanks for contributing!
> 
> Sam
> 
> On 28/08/18 13:59, andrey simiklit wrote:
> > Hi all,
> > 
> > Could somebody push it if it seems good for all?
> > 
> > Regards,
> > Andrii.
> > 
> > On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez
> > 
> > <siglesias at igalia.com <mailto:siglesias at igalia.com>> wrote:
> >     The patch seems fine to me. I also tested it on Intel CI and there
> >     were no regressions.
> >     
> >     Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> >     <mailto:siglesias at igalia.com>
> >     
> >     Thanks,
> >     
> >     Sam
> >     
> >     On 15/08/18 17:20, asimiklit.work at gmail.com
> >     
> >     <mailto:asimiklit.work at gmail.com> wrote:
> >>     From: Andrii Simiklit <asimiklit.work at gmail.com>
> >>     <mailto:asimiklit.work at gmail.com>
> >>     
> >>     When the SVBI Payload Enable is false I guess the register R1.4
> >>     which contains the Maximum Streamed Vertex Buffer Index is filled by
> >>     zero
> >>     and GS stops to write transform feedback when the transform feedback
> >>     is not active.
> >>     
> >>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> >>     Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
> >>     <mailto:andrii.simiklit at globallogic.com>
> >>     ---
> >>     
> >>      src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
> >>      1 file changed, 1 insertion(+), 1 deletion(-)
> >>     
> >>     diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> >>     b/src/mesa/drivers/dri/i965/genX_state_upload.c index
> >>     ea5ad55..0f82500 100644
> >>     --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> >>     +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> >>     @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
> >>     
> >>      #if GEN_GEN < 7
> >>      
> >>               gs.SOStatisticsEnable = true;
> >>               if (gs_prog->info.has_transform_feedback_varyings)
> >>     
> >>     -            gs.SVBIPayloadEnable = true;
> >>     +            gs.SVBIPayloadEnable =
> >>     _mesa_is_xfb_active_and_unpaused(ctx);
> >>     
> >>               /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are
> >>               enabled as it
> >>               
> >>                * was previously done for gen6.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180828/94ec6be7/attachment-0001.sig>