[Mesa-dev] [PATCH 1/5] meson: Actually load translation files

Eric Engestrom eric.engestrom at intel.com
Tue Aug 28 14:34:26 UTC 2018


On Friday, 2018-08-24 07:13:41 -0700, Dylan Baker wrote:
> Currently we run the script but don't actually load any files, even in a
> tarball where they exist.
> 
> Fixes: 3218056e0eb375eeda470058d06add1532acd6d4
>        ("meson: Build i965 and dri stack")
> ---
>  src/util/xmlpool/meson.build | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/util/xmlpool/meson.build b/src/util/xmlpool/meson.build
> index 346b1956a55..3d2de0cdc3a 100644
> --- a/src/util/xmlpool/meson.build
> +++ b/src/util/xmlpool/meson.build
> @@ -22,7 +22,10 @@ xmlpool_options_h = custom_target(
>    'xmlpool_options.h',
>    input : ['gen_xmlpool.py', 't_options.h'],
>    output : 'options.h',
> -  command : [prog_python, '@INPUT@', meson.current_source_dir()],
> +  command : [
> +    prog_python, '@INPUT@', meson.current_source_dir(),
> +    'ca', 'es', 'de', 'nl', 'sv', 'fr',
> +  ],
>    capture : true,
>    depend_files : files('ca.po', 'es.po', 'de.po', 'nl.po', 'sv.po', 'fr.po'),

Nit: I would put that lang list in an array and reuse it to generate the list
of `depend_files` here, to keep it in sync, but that can be a follow up
patch (happy to do it).

Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

>  )
> -- 
> 2.18.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list