[Mesa-dev] [PATCH 0/2] Implement INTEL_fragment_shader_ordering

[Mark Janes]

"Manolova, Plamena" <plamena.manolova at intel.com> writes:

> Hi Mark,
> AFAIK there is no piglit test for this specific extension. However
> underneath the hood it reuses the functionality of
> ARB_fragment_shader_interlock, which has a test. I believe the only
> major difference between the two extensions is that unlike
> beginInvocationInterlockARB, beginFragmentShaderOrderingINTEL can be
> called from functions other than main(). If necessary it would be
> pretty straightforward to reuse most of the code for the
> ARB_fragment_shader_interlock test to create one for
> INTEL_fragment_shader_ordering.

Sounds like a good plan!

> Thank you,
> Pam
>
> On Tue, Aug 28, 2018 at 6:41 PM Mark Janes <mark.a.janes at intel.com> wrote:
>
>> Is there a piglit test that verifies that this feature works properly?
>>
>> <kevin.rogovin at intel.com> writes:
>>
>> > From: Kevin Rogovin <kevin.rogovin at intel.com>
>> >
>> > INTEL_fragment_shader_ordering provides the ability for shaders
>> > to issue a call to gaurnantee memory write operation ordering
>> > of overlapping pixels or samples. In contrast to
>> > ARB_fragment_shader_interlock, INTEL_fragment_shader_ordering
>> > instead of defining a critical region (which must be in main() and
>> > under no flow control) provides a single function that acts like
>> > a memory barrier that can be called under any control flow.
>> >
>> > Kevin Rogovin (2):
>> >   mesa: Add GL/GLSL plumbing for INTEL_fragment_shader_ordering.
>> >   i965: Add INTEL_fragment_shader_ordering support.
>> >
>> >  docs/relnotes/18.3.0.html                    |  1 +
>> >  src/compiler/glsl/builtin_functions.cpp      | 17 +++++++++++++++++
>> >  src/compiler/glsl/glsl_parser_extras.cpp     |  1 +
>> >  src/compiler/glsl/glsl_parser_extras.h       |  2 ++
>> >  src/compiler/glsl/glsl_to_nir.cpp            |  6 ++++++
>> >  src/compiler/glsl/ir.h                       |  1 +
>> >  src/compiler/nir/nir_intrinsics.py           |  1 +
>> >  src/intel/compiler/brw_fs_nir.cpp            |  1 +
>> >  src/mesa/drivers/dri/i965/intel_extensions.c |  1 +
>> >  src/mesa/main/extensions_table.h             |  1 +
>> >  src/mesa/main/mtypes.h                       |  1 +
>> >  11 files changed, 33 insertions(+)
>> >
>> > --
>> > 2.17.1
>> >
>> > _______________________________________________
>> > mesa-dev mailing list
>> > mesa-dev at lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>