[Mesa-dev] [PATCH 07/14] st/mesa: set ctx->Const.SubPixelBits

[Marek Olšák]

On Tue, Aug 28, 2018 at 7:40 AM, Jakob Bornecrantz <jakob at collabora.com> wrote:
> On Thu, Aug 9, 2018 at 12:57 AM Marek Olšák <maraeo at gmail.com> wrote:
>>
>> From: Marek Olšák <marek.olsak at amd.com>
>
> This patch causes regressions in dEQP[1] on virgl running on a
> radeonSI device. Not a lot of drivers set
> PIPE_CAP_VIEWPORT_SUBPIXEL_BITS but SubPixelBits is by default set to
> 4, but this overwrites it without checking if the returned value is
> zero or not. Looking around it seems that a lot of other drivers just
> returns zero for PIPE_CAP_VIEWPORT_SUBPIXEL_BITS not just virgl, so
> this probably causes regressions on more drivers then virgl.

That's a good thing. It shows us that some drivers report some caps incorrectly.

Marek