[Mesa-dev] [PATCH] gallium: fix drivers to report something for PIPE_CAP_VIEWPORT_SUBPIXEL_BITS

Roland Scheidegger sroland at vmware.com
Tue Aug 28 18:49:40 UTC 2018


This is not correct.

The problem here is that there's only a viewport subpixel accuracy
query, but the state tracker uses this to both set subpixel (which is
raterization subpixel accuracy) as well as viewport subpixel bits.
The former needs to be at least 4 (dx10 requires 8), whereas the latter
still is ok to be 0.

For instance, llvmpipe and probably a bunch of other drivers would have
8 subpixel bits for rasterization, but they use actual integers for
viewport bounds, hence 0 bits. It would be incorrect to report 8 bits
for viewport accuracy (even though without msaa it matters little).

So I suspect to fix this properly you'd need a new pipe cap bit (whereas
0 as default for viewport subpixels would be just fine, but not for
rasterization subpixel).

Roland



Am 28.08.2018 um 20:19 schrieb Marek Olšák:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> ---
>  src/gallium/drivers/etnaviv/etnaviv_screen.c     | 4 +++-
>  src/gallium/drivers/freedreno/freedreno_screen.c | 4 +++-
>  src/gallium/drivers/i915/i915_screen.c           | 4 +++-
>  src/gallium/drivers/llvmpipe/lp_screen.c         | 3 ++-
>  src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 3 ++-
>  src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 4 +++-
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 4 +++-
>  src/gallium/drivers/r300/r300_screen.c           | 5 ++++-
>  src/gallium/drivers/softpipe/sp_screen.c         | 3 ++-
>  src/gallium/drivers/svga/svga_screen.c           | 4 +++-
>  src/gallium/drivers/swr/swr_screen.cpp           | 4 +++-
>  src/gallium/drivers/v3d/v3d_screen.c             | 4 +++-
>  src/gallium/drivers/vc4/vc4_screen.c             | 4 +++-
>  src/gallium/drivers/virgl/virgl_screen.c         | 3 ++-
>  14 files changed, 39 insertions(+), 14 deletions(-)
> 
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index 9669bd2f601..4fe1c9ebead 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> @@ -162,20 +162,23 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>                        NON_POWER_OF_TWO); */
>  
>     case PIPE_CAP_TEXTURE_SWIZZLE:
>     case PIPE_CAP_PRIMITIVE_RESTART:
>        return VIV_FEATURE(screen, chipMinorFeatures1, HALTI0);
>  
>     case PIPE_CAP_ENDIANNESS:
>        return PIPE_ENDIAN_LITTLE; /* on most Viv hw this is configurable (feature
>                                      ENDIANNESS_CONFIG) */
>  
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
> +
>     /* Unsupported features. */
>     case PIPE_CAP_SEAMLESS_CUBE_MAP:
>     case PIPE_CAP_COMPUTE: /* XXX supported on gc2000 */
>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS: /* only one colorbuffer supported, so mixing makes no sense */
>     case PIPE_CAP_CONDITIONAL_RENDER: /* no occlusion queries */
>     case PIPE_CAP_TGSI_INSTANCEID: /* no idea, really */
>     case PIPE_CAP_START_INSTANCE: /* instancing not supported AFAIK */
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR: /* instancing not supported AFAIK */
>     case PIPE_CAP_SHADER_STENCIL_EXPORT: /* Fragment shader cannot export stencil value */
>     case PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS: /* no dual-source supported */
> @@ -237,21 +240,20 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_SURFACE_REINTERPRET_BLOCKS:
>     case PIPE_CAP_QUERY_BUFFER_OBJECT:
>     case PIPE_CAP_QUERY_MEMORY_INFO:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>     case PIPE_CAP_CULL_DISTANCE:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>     case PIPE_CAP_STREAM_OUTPUT_INTERLEAVE_BUFFERS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_DOUBLES:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_TGSI_TEX_TXF_LZ:
> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
> index 489986703cd..394edbcd1fe 100644
> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
> @@ -291,20 +291,23 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>  	case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
>  		if (is_a5xx(screen) || is_a6xx(screen))
>  			return 4;
>  		return 0;
>  
>  	case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS:
>  		if (is_a4xx(screen) || is_a5xx(screen) || is_a6xx(screen))
>  			return 4;
>  		return 0;
>  
> +	case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +		return 8;
> +
>  	/* Unsupported features. */
>  	case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
>  	case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
>  	case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
>  	case PIPE_CAP_USER_VERTEX_BUFFERS:
>  	case PIPE_CAP_QUERY_PIPELINE_STATISTICS:
>  	case PIPE_CAP_TEXTURE_BORDER_COLOR_QUIRK:
>  	case PIPE_CAP_TGSI_VS_LAYER_VIEWPORT:
>  	case PIPE_CAP_TEXTURE_GATHER_SM5:
>  	case PIPE_CAP_SAMPLE_SHADING:
> @@ -328,21 +331,20 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>  	case PIPE_CAP_TGSI_FS_POSITION_IS_SYSVAL:
>  	case PIPE_CAP_TGSI_FS_FACE_IS_INTEGER_SYSVAL:
>  	case PIPE_CAP_GENERATE_MIPMAP:
>  	case PIPE_CAP_SURFACE_REINTERPRET_BLOCKS:
>  	case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>  	case PIPE_CAP_CULL_DISTANCE:
>  	case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>  	case PIPE_CAP_TGSI_VOTE:
>  	case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>  	case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -	case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>  	case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>  	case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>  	case PIPE_CAP_TGSI_FS_FBFETCH:
>  	case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>  	case PIPE_CAP_DOUBLES:
>  	case PIPE_CAP_INT64:
>  	case PIPE_CAP_INT64_DIVMOD:
>  	case PIPE_CAP_TGSI_TEX_TXF_LZ:
>  	case PIPE_CAP_TGSI_CLOCK:
>  	case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
> diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
> index 103725ca5c8..afe6d81bb7f 100644
> --- a/src/gallium/drivers/i915/i915_screen.c
> +++ b/src/gallium/drivers/i915/i915_screen.c
> @@ -200,20 +200,23 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
>     case PIPE_CAP_POINT_SPRITE:
>     case PIPE_CAP_PRIMITIVE_RESTART: /* draw module */
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>     case PIPE_CAP_BLEND_EQUATION_SEPARATE:
>     case PIPE_CAP_TGSI_INSTANCEID:
>     case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
>     case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
>        return 1;
>  
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 4;
> +
>     /* Unsupported features (boolean caps). */
>     case PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS:
>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>     case PIPE_CAP_INDEP_BLEND_ENABLE:
>     case PIPE_CAP_INDEP_BLEND_FUNC:
>     case PIPE_CAP_SHADER_STENCIL_EXPORT:
>     case PIPE_CAP_TEXTURE_MIRROR_CLAMP:
>     case PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE:
>     case PIPE_CAP_TEXTURE_SWIZZLE:
>     case PIPE_CAP_QUERY_TIME_ELAPSED:
> @@ -298,21 +301,20 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_TGSI_VS_LAYER_VIEWPORT:
>     case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>     case PIPE_CAP_DRAW_INDIRECT:
>     case PIPE_CAP_MULTI_DRAW_INDIRECT:
>     case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_DOUBLES:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_TGSI_TEX_TXF_LZ:
>     case PIPE_CAP_TGSI_CLOCK:
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index dacd9219756..a8e93f1ad6d 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -300,20 +300,22 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_POLYGON_OFFSET_CLAMP:
>     case PIPE_CAP_TEXTURE_FLOAT_LINEAR:
>     case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR:
>        return 1;
>     case PIPE_CAP_CULL_DISTANCE:
>        return 1;
>     case PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS:
>        return 1;
>     case PIPE_CAP_CLEAR_TEXTURE:
>        return 1;
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
>     case PIPE_CAP_MULTISAMPLE_Z_RESOLVE:
>     case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
>     case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
>     case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
>     case PIPE_CAP_DEPTH_BOUNDS_TEST:
>     case PIPE_CAP_TGSI_TXQS:
>     case PIPE_CAP_FORCE_PERSAMPLE_INTERP:
>     case PIPE_CAP_SHAREABLE_SHADERS:
>     case PIPE_CAP_DRAW_PARAMETERS:
>     case PIPE_CAP_TGSI_PACK_HALF_FLOAT:
> @@ -332,21 +334,20 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_PCI_GROUP:
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_TGSI_CLOCK:
>     case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
>     case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
>     case PIPE_CAP_TGSI_BALLOT:
>     case PIPE_CAP_TGSI_TES_LAYER_VIEWPORT:
> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> index da7ebecd5d7..914d378e96d 100644
> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> @@ -100,20 +100,22 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_DEPTH_BOUNDS_TEST:
>        return eng3d->oclass == NV35_3D_CLASS || eng3d->oclass >= NV40_3D_CLASS;
>     /* nv4x capabilities */
>     case PIPE_CAP_BLEND_EQUATION_SEPARATE:
>     case PIPE_CAP_NPOT_TEXTURES:
>     case PIPE_CAP_CONDITIONAL_RENDER:
>     case PIPE_CAP_TEXTURE_MIRROR_CLAMP:
>     case PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE:
>     case PIPE_CAP_PRIMITIVE_RESTART:
>        return (eng3d->oclass >= NV40_3D_CLASS) ? 1 : 0;
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
>     /* unsupported */
>     case PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS:
>     case PIPE_CAP_SM3:
>     case PIPE_CAP_INDEP_BLEND_ENABLE:
>     case PIPE_CAP_INDEP_BLEND_FUNC:
>     case PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS:
>     case PIPE_CAP_SHADER_STENCIL_EXPORT:
>     case PIPE_CAP_TGSI_INSTANCEID:
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR: /* XXX: yes? */
>     case PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS:
> @@ -192,21 +194,20 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>     case PIPE_CAP_CULL_DISTANCE:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
>     case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_DOUBLES:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> index 16c334e9be4..0282c1ee41e 100644
> --- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> @@ -210,20 +210,23 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
>        return class_3d >= NVA0_3D_CLASS;
>     /* supported on nva3+ */
>     case PIPE_CAP_CUBE_MAP_ARRAY:
>     case PIPE_CAP_INDEP_BLEND_FUNC:
>     case PIPE_CAP_TEXTURE_QUERY_LOD:
>     case PIPE_CAP_SAMPLE_SHADING:
>     case PIPE_CAP_FORCE_PERSAMPLE_INTERP:
>        return class_3d >= NVA3_3D_CLASS;
>  
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
> +
>     /* unsupported caps */
>     case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
>     case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
>     case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
>     case PIPE_CAP_SHADER_STENCIL_EXPORT:
>     case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_TGSI_TEXCOORD:
> @@ -251,21 +254,20 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_QUERY_MEMORY_INFO:
>     case PIPE_CAP_PCI_GROUP:
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_STREAM_OUTPUT_INTERLEAVE_BUFFERS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_DOUBLES:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
>     case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index 802483038ef..ef18f1515f4 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -272,20 +272,23 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>        return 32;
>     case PIPE_CAP_MAX_SHADER_BUFFER_SIZE:
>        return 1 << 27;
>     case PIPE_CAP_CONSERVATIVE_RASTER_PRE_SNAP_TRIANGLES:
>        return class_3d >= GP100_3D_CLASS;
>     case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
>     case PIPE_CAP_TGSI_BALLOT:
>     case PIPE_CAP_BINDLESS_TEXTURE:
>        return class_3d >= NVE4_3D_CLASS;
>  
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
> +
>     /* unsupported caps */
>     case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
>     case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
>     case PIPE_CAP_SHADER_STENCIL_EXPORT:
>     case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_FAKE_SW_MSAA:
>     case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
> @@ -294,21 +297,20 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
>     case PIPE_CAP_TGSI_FS_POSITION_IS_SYSVAL:
>     case PIPE_CAP_GENERATE_MIPMAP:
>     case PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY:
>     case PIPE_CAP_SURFACE_REINTERPRET_BLOCKS:
>     case PIPE_CAP_QUERY_MEMORY_INFO:
>     case PIPE_CAP_PCI_GROUP:
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
>     case PIPE_CAP_NIR_SAMPLERS_AS_DEREF:
>     case PIPE_CAP_MEMOBJ:
>     case PIPE_CAP_LOAD_CONSTBUF:
>     case PIPE_CAP_TGSI_ANY_REG_AS_ADDRESS:
>     case PIPE_CAP_TILE_RASTER_ORDER:
> diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
> index 01a95d98dcf..65ef9244a79 100644
> --- a/src/gallium/drivers/r300/r300_screen.c
> +++ b/src/gallium/drivers/r300/r300_screen.c
> @@ -132,20 +132,24 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>           * intepolators for generic varyings. */
>          case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>              return !is_r500;
>  
>          /* Supported on r500 only. */
>          case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
>          case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>          case PIPE_CAP_SM3:
>              return is_r500 ? 1 : 0;
>  
> +        case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +	    /* the subpixel grid is 12x12, so bits are exactly log2(12) = 3.585 */
> +            return 3;
> +
>          /* Unsupported features. */
>          case PIPE_CAP_QUERY_TIME_ELAPSED:
>          case PIPE_CAP_QUERY_PIPELINE_STATISTICS:
>          case PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS:
>          case PIPE_CAP_INDEP_BLEND_ENABLE:
>          case PIPE_CAP_INDEP_BLEND_FUNC:
>          case PIPE_CAP_DEPTH_CLIP_DISABLE:
>          case PIPE_CAP_SHADER_STENCIL_EXPORT:
>          case PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS:
>          case PIPE_CAP_TGSI_INSTANCEID:
> @@ -215,21 +219,20 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>          case PIPE_CAP_SURFACE_REINTERPRET_BLOCKS:
>          case PIPE_CAP_QUERY_BUFFER_OBJECT:
>          case PIPE_CAP_QUERY_MEMORY_INFO:
>          case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>          case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>          case PIPE_CAP_CULL_DISTANCE:
>          case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>          case PIPE_CAP_TGSI_VOTE:
>          case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>          case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -        case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>          case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>          case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>          case PIPE_CAP_NATIVE_FENCE_FD:
>          case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>          case PIPE_CAP_TGSI_FS_FBFETCH:
>          case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>          case PIPE_CAP_DOUBLES:
>          case PIPE_CAP_INT64:
>          case PIPE_CAP_INT64_DIVMOD:
>          case PIPE_CAP_TGSI_TEX_TXF_LZ:
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
> index db32c9e3b32..0eead03b086 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -255,20 +255,22 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>        return 1;
>     case PIPE_CAP_VERTEXID_NOBASE:
>        return 0;
>     case PIPE_CAP_POLYGON_OFFSET_CLAMP:
>        return 0;
>     case PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS:
>     case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>        return 1;
>     case PIPE_CAP_CLEAR_TEXTURE:
>        return 1;
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
>     case PIPE_CAP_MULTISAMPLE_Z_RESOLVE:
>     case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
>     case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
>     case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
>     case PIPE_CAP_DEPTH_BOUNDS_TEST:
>     case PIPE_CAP_TGSI_TXQS:
>     case PIPE_CAP_FORCE_PERSAMPLE_INTERP:
>     case PIPE_CAP_SHAREABLE_SHADERS:
>     case PIPE_CAP_DRAW_PARAMETERS:
>     case PIPE_CAP_TGSI_PACK_HALF_FLOAT:
> @@ -284,21 +286,20 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_QUERY_MEMORY_INFO:
>     case PIPE_CAP_PCI_GROUP:
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_TGSI_CLOCK:
>     case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
>     case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
>     case PIPE_CAP_TGSI_BALLOT:
>     case PIPE_CAP_TGSI_TES_LAYER_VIEWPORT:
> diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c
> index 54c49d165f7..2bddac33ed1 100644
> --- a/src/gallium/drivers/svga/svga_screen.c
> +++ b/src/gallium/drivers/svga/svga_screen.c
> @@ -397,20 +397,23 @@ svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>        return 1;  /* need 4-byte alignment for all offsets and strides */
>     case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
>        return 2048;
>     case PIPE_CAP_MAX_VIEWPORTS:
>        return 1;
>     case PIPE_CAP_ENDIANNESS:
>        return PIPE_ENDIAN_LITTLE;
>  
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
> +
>     case PIPE_CAP_VENDOR_ID:
>        return 0x15ad; /* VMware Inc. */
>     case PIPE_CAP_DEVICE_ID:
>        return 0x0405; /* assume SVGA II */
>     case PIPE_CAP_ACCELERATED:
>        return 0; /* XXX: */
>     case PIPE_CAP_VIDEO_MEMORY:
>        /* XXX: Query the host ? */
>        return 1;
>     case PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS:
> @@ -431,21 +434,20 @@ svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_FS_POSITION_IS_SYSVAL:
>     case PIPE_CAP_TGSI_FS_FACE_IS_INTEGER_SYSVAL:
>     case PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY:
>     case PIPE_CAP_QUERY_BUFFER_OBJECT:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_CULL_DISTANCE:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_DOUBLES:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_TGSI_TEX_TXF_LZ:
>     case PIPE_CAP_TGSI_CLOCK:
> diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp
> index 706ed5621cd..28e1cb1a836 100644
> --- a/src/gallium/drivers/swr/swr_screen.cpp
> +++ b/src/gallium/drivers/swr/swr_screen.cpp
> @@ -262,20 +262,23 @@ swr_get_param(struct pipe_screen *screen, enum pipe_cap param)
>        return (swr_screen(screen)->msaa_max_count > 1) ? 1 : 0;
>     case PIPE_CAP_FAKE_SW_MSAA:
>        return (swr_screen(screen)->msaa_max_count > 1) ? 0 : 1;
>  
>     /* fetch jit change for 2-4GB buffers requires alignment */
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>        return 1;
>  
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
> +
>        /* unsupported features */
>     case PIPE_CAP_ANISOTROPIC_FILTER:
>     case PIPE_CAP_TEXTURE_BORDER_COLOR_QUIRK:
>     case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
>     case PIPE_CAP_SHADER_STENCIL_EXPORT:
>     case PIPE_CAP_TEXTURE_BARRIER:
>     case PIPE_CAP_FRAGMENT_COLOR_CLAMPED:
>     case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>     case PIPE_CAP_COMPUTE:
>     case PIPE_CAP_TGSI_VS_LAYER_VIEWPORT:
> @@ -315,21 +318,20 @@ swr_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>     case PIPE_CAP_PCI_GROUP:
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
>     case PIPE_CAP_NATIVE_FENCE_FD:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_TGSI_TEX_TXF_LZ:
> diff --git a/src/gallium/drivers/v3d/v3d_screen.c b/src/gallium/drivers/v3d/v3d_screen.c
> index 8a166c18fa7..5a047572f88 100644
> --- a/src/gallium/drivers/v3d/v3d_screen.c
> +++ b/src/gallium/drivers/v3d/v3d_screen.c
> @@ -158,20 +158,23 @@ v3d_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>          case PIPE_CAP_MAX_STREAM_OUTPUT_INTERLEAVED_COMPONENTS:
>                  return 64;
>  
>          case PIPE_CAP_MIN_TEXEL_OFFSET:
>          case PIPE_CAP_MIN_TEXTURE_GATHER_OFFSET:
>                  return -8;
>          case PIPE_CAP_MAX_TEXEL_OFFSET:
>          case PIPE_CAP_MAX_TEXTURE_GATHER_OFFSET:
>                  return 7;
>  
> +	case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +		return 8;
> +
>                  /* Unsupported features. */
>          case PIPE_CAP_ANISOTROPIC_FILTER:
>          case PIPE_CAP_TEXTURE_BUFFER_OBJECTS:
>          case PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY:
>          case PIPE_CAP_CUBE_MAP_ARRAY:
>          case PIPE_CAP_TEXTURE_MIRROR_CLAMP:
>          case PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE:
>          case PIPE_CAP_SEAMLESS_CUBE_MAP:
>          case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>          case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
> @@ -231,21 +234,20 @@ v3d_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>          case PIPE_CAP_PCI_BUS:
>          case PIPE_CAP_PCI_DEVICE:
>          case PIPE_CAP_PCI_FUNCTION:
>          case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>          case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>          case PIPE_CAP_CULL_DISTANCE:
>          case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>          case PIPE_CAP_TGSI_VOTE:
>          case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>          case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -        case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>          case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>          case PIPE_CAP_TGSI_FS_FBFETCH:
>          case PIPE_CAP_INT64:
>          case PIPE_CAP_INT64_DIVMOD:
>          case PIPE_CAP_DOUBLES:
>          case PIPE_CAP_BINDLESS_TEXTURE:
>          case PIPE_CAP_POST_DEPTH_COVERAGE:
>          case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>          case PIPE_CAP_TGSI_BALLOT:
>          case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
> diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c
> index b88110a86c5..6d84a46e5c3 100644
> --- a/src/gallium/drivers/vc4/vc4_screen.c
> +++ b/src/gallium/drivers/vc4/vc4_screen.c
> @@ -171,20 +171,23 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>                  return 1;
>  
>          case PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT:
>          case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
>                  return 1;
>  
>          case PIPE_CAP_MIXED_FRAMEBUFFER_SIZES:
>          case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
>                  return 1;
>  
> +	case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +		return 8;
> +
>                  /* Unsupported features. */
>          case PIPE_CAP_ANISOTROPIC_FILTER:
>          case PIPE_CAP_TEXTURE_BUFFER_OBJECTS:
>          case PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY:
>          case PIPE_CAP_CUBE_MAP_ARRAY:
>          case PIPE_CAP_TEXTURE_MIRROR_CLAMP:
>          case PIPE_CAP_TEXTURE_MIRROR_CLAMP_TO_EDGE:
>          case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>          case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>          case PIPE_CAP_SEAMLESS_CUBE_MAP:
> @@ -258,21 +261,20 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>          case PIPE_CAP_PCI_BUS:
>          case PIPE_CAP_PCI_DEVICE:
>          case PIPE_CAP_PCI_FUNCTION:
>          case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>          case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>          case PIPE_CAP_CULL_DISTANCE:
>          case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>          case PIPE_CAP_TGSI_VOTE:
>          case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>          case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -        case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>          case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>          case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>          case PIPE_CAP_TGSI_FS_FBFETCH:
>          case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>          case PIPE_CAP_DOUBLES:
>          case PIPE_CAP_INT64:
>          case PIPE_CAP_INT64_DIVMOD:
>          case PIPE_CAP_TGSI_TEX_TXF_LZ:
>          case PIPE_CAP_TGSI_CLOCK:
>          case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
> diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c
> index dd97b3d3f96..9bfcb7264c2 100644
> --- a/src/gallium/drivers/virgl/virgl_screen.c
> +++ b/src/gallium/drivers/virgl/virgl_screen.c
> @@ -240,20 +240,22 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>        return vscreen->caps.caps.v2.capability_bits & VIRGL_CAP_FB_NO_ATTACH;
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
>        return vscreen->caps.caps.v2.capability_bits & VIRGL_CAP_ROBUST_BUFFER_ACCESS;
>     case PIPE_CAP_TGSI_FS_FBFETCH:
>        return vscreen->caps.caps.v2.capability_bits & VIRGL_CAP_TGSI_FBFETCH;
>     case PIPE_CAP_TGSI_CLOCK:
>        return vscreen->caps.caps.v2.capability_bits & VIRGL_CAP_SHADER_CLOCK;
>     case PIPE_CAP_TGSI_ARRAY_COMPONENTS:
>        return vscreen->caps.caps.v2.capability_bits & VIRGL_CAP_TGSI_COMPONENTS;
> +   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
> +      return 8;
>     case PIPE_CAP_TEXTURE_GATHER_SM5:
>     case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>     case PIPE_CAP_FAKE_SW_MSAA:
>     case PIPE_CAP_TEXTURE_GATHER_OFFSETS:
>     case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>     case PIPE_CAP_MULTI_DRAW_INDIRECT:
>     case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_CLIP_HALFZ:
>     case PIPE_CAP_VERTEXID_NOBASE:
>     case PIPE_CAP_MULTISAMPLE_Z_RESOLVE:
> @@ -275,21 +277,20 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_STRING_MARKER:
>     case PIPE_CAP_QUERY_MEMORY_INFO:
>     case PIPE_CAP_PCI_GROUP:
>     case PIPE_CAP_PCI_BUS:
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_PRIMITIVE_RESTART_FOR_PATCHES:
>     case PIPE_CAP_TGSI_VOTE:
>     case PIPE_CAP_MAX_WINDOW_RECTANGLES:
>     case PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED:
> -   case PIPE_CAP_VIEWPORT_SUBPIXEL_BITS:
>     case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
>     case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>     case PIPE_CAP_TGSI_MUL_ZERO_WINS:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>     case PIPE_CAP_TGSI_TEX_TXF_LZ:
>     case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
>     case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
>     case PIPE_CAP_TGSI_BALLOT:
>     case PIPE_CAP_TGSI_TES_LAYER_VIEWPORT:
> 



More information about the mesa-dev mailing list