[Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active
Samuel Iglesias Gonsálvez
siglesias at igalia.com
Wed Aug 29 06:13:12 UTC 2018
On 28/08/18 23:41, Andres Gomez wrote:
> Andrii, Samuel, should we also include this in the stable queues ?
Yes, please. Add it to stable queue.
> On Wed, 2018-08-15 at 18:20 +0300, asimiklit.work at gmail.com wrote:
>> From: Andrii Simiklit <asimiklit.work at gmail.com>
>> When the SVBI Payload Enable is false I guess the register R1.4
>> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
>> and GS stops to write transform feedback when the transform feedback
>> is not active.
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
>> Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
>> src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
>> index ea5ad55..0f82500 100644
>> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
>> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
>> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>> #if GEN_GEN < 7
>> gs.SOStatisticsEnable = true;
>> if (gs_prog->info.has_transform_feedback_varyings)
>> - gs.SVBIPayloadEnable = true;
>> + gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
>> /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it
>> * was previously done for gen6.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the mesa-dev