[Mesa-dev] [PATCH 03/10] egl: add EGL_MESA_device_software support

Emil Velikov emil.l.velikov at gmail.com
Wed Aug 29 12:16:23 UTC 2018


On 29 August 2018 at 12:47, Eric Engestrom <eric.engestrom at intel.com> wrote:

>> +{
>> +   _EGLDevice *dev;
>> +
>> +   mtx_lock(_eglGlobal.Mutex);
>> +   dev = _eglGlobal.DeviceList;
>> +   /* The first device is always software */
>> +   if (!dev) {
>> +      _eglGlobal.DeviceList = &software_device;
>> +      dev = _eglGlobal.DeviceList;
>> +   }
>
> You could avoid that (duplicated) runtime logic by just putting that
> line in the initialisation of `_eglGlobal`
>
Ack. Can init upon declaration [in eglglobal.c].

Will fix that and use your name suggestions with v2.

-Emil


More information about the mesa-dev mailing list