[Mesa-dev] [PATCH 21/22] anv, i965: Lower away image derefs in the driver

[Kenneth Graunke]

On Friday, August 17, 2018 1:06:27 PM PDT Jason Ekstrand wrote:
> Previously, the back-end compiler turn image access into magic uniform
> reads and there was a complex contract between back-end compiler and
> driver about setting up and filling out those params.  As of this
> commit, both drivers now lower image_deref_load_param_intel intrinsics
> to load_uniform intrinsics controlled by the driver and lower the other
> image_deref_* intrinsics to image_* intrinsics which take an actual
> binding table index.  There are still "magic" uniforms but they are now
> added and controlled entirely by the driver and that contract no longer
> spans components.
> 
> This also has the side-effect of making most image use compile-time
> binding table indices.  Previously, all image access pulled the binding
> table index from a uniform.  Part of the reason for this was that the
> magic uniforms made it difficult to decouple binding table indices from
> the uniforms and, since they are indexed completely differently
> (especially in Vulkan), it was hard to pull them apart.  Now that the
> driver is handling both, it's trivial to decouple the two and provide
> actual binding table indices.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180829/a959aa88/attachment.sig>