[Mesa-dev] [PATCH v2 14/22] intel/compiler: Do image load/store lowering to NIR

[Kenneth Graunke]

On Wednesday, August 29, 2018 10:11:48 AM PDT Jason Ekstrand wrote:
> This commit moves our storage image format conversion codegen into NIR
> instead of doing it in the back-end.  This has the advantage of letting
> us run it through NIR's optimizer which is pretty effective at shrinking
> things down.  In the common case of rgba8, the number of instructions
> emitted after NIR is done with it is half of what it was with the
> lowering happening in the back-end.  On the downside, the back-end's
> lowering is able to directly use predicates and the NIR lowering has to
> use IFs.
> 
> Shader-db results on Kaby Lake:
> 
>     total instructions in shared programs: 15166910 -> 15166872 (<.01%)
>     instructions in affected programs: 5895 -> 5857 (-0.64%)
>     helped: 15
>     HURT: 0
> 
> Clearly, we don't have that much image_load_store happening in the
> shaders in shader-db....

Looks like the untyped stride checks are back and the unnecessary typed
load checks (mistakenly copied from atomics) are gone.  Nice.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180829/56a444fa/attachment-0001.sig>