[Mesa-dev] [PATCH] radv: Add missing checks in radv_get_image_format_properties.

[Samuel Pitoiset]

Sounds reasonable to me.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 8/29/18 5:14 PM, Bas Nieuwenhuizen wrote:
> CC: <mesa-stable at lists.freedesktop.org>
> ---
>   src/amd/vulkan/radv_formats.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
> index f0cc0fc5f95..6253c27b95d 100644
> --- a/src/amd/vulkan/radv_formats.c
> +++ b/src/amd/vulkan/radv_formats.c
> @@ -1112,6 +1112,25 @@ static VkResult radv_get_image_format_properties(struct radv_physical_device *ph
>   		}
>   	}
>   
> +	if (info->usage & VK_IMAGE_USAGE_TRANSFER_SRC_BIT) {
> +		if (!(format_feature_flags & VK_FORMAT_FEATURE_TRANSFER_SRC_BIT)) {
> +			goto unsupported;
> +		}
> +	}
> +
> +	if (info->usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT) {
> +		if (!(format_feature_flags & VK_FORMAT_FEATURE_TRANSFER_DST_BIT)) {
> +			goto unsupported;
> +		}
> +	}
> +
> +	if (info->usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) {
> +		if (!(format_feature_flags & (VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT |
> +		                              VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT))) {
> +			goto unsupported;
> +		}
> +	}
> +
>   	*pImageFormatProperties = (VkImageFormatProperties) {
>   		.maxExtent = maxExtent,
>   		.maxMipLevels = maxMipLevels,
>