[Mesa-dev] [PATCH] intel/nir: Lowering image loads and stores trashes all metadata
Jason Ekstrand
jason at jlekstrand.net
Thu Aug 30 18:31:30 UTC 2018
This fixes the GL_ARB_fragment_shader_interlock piglit test on gen8
platforms where the lack of metadata dirtying was causing another pass
to accidentally delete a much needed loop.
Cc: Kenneth Graunke <kenneth at whitecape.org>
https://bugs.freedesktop.org/show_bug.cgi?id=107745
Fixes: 37f7983bcca1 "intel/compiler: Do image load/store lowering..."
---
src/intel/compiler/brw_nir_lower_image_load_store.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/compiler/brw_nir_lower_image_load_store.c b/src/intel/compiler/brw_nir_lower_image_load_store.c
index de6f7683be4..e8083a80cb7 100644
--- a/src/intel/compiler/brw_nir_lower_image_load_store.c
+++ b/src/intel/compiler/brw_nir_lower_image_load_store.c
@@ -817,8 +817,8 @@ brw_nir_lower_image_load_store(nir_shader *shader,
}
}
- nir_metadata_preserve(function->impl, nir_metadata_block_index |
- nir_metadata_dominance);
+ if (progress)
+ nir_metadata_preserve(function->impl, nir_metadata_none);
}
return progress;
--
2.17.1
More information about the mesa-dev
mailing list