[Mesa-dev] [PATCH 7/7] radv: remove dead code in scan_shader_output_decl()

Dave Airlie airlied at gmail.com
Fri Aug 31 00:36:07 UTC 2018


Assuming it all has no CTS regressions, and GTAV works.

Reviewed-by: Dave Airlie <airlied at redhat.com> for the series.
On Thu, 30 Aug 2018 at 18:59, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
>
> Never used.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_nir_to_llvm.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
> index b2411fe38b..af34c548c1 100644
> --- a/src/amd/vulkan/radv_nir_to_llvm.c
> +++ b/src/amd/vulkan/radv_nir_to_llvm.c
> @@ -2241,8 +2241,6 @@ scan_shader_output_decl(struct radv_shader_context *ctx,
>             stage == MESA_SHADER_TESS_EVAL ||
>             stage == MESA_SHADER_GEOMETRY) {
>                 if (idx == VARYING_SLOT_CLIP_DIST0) {
> -                       int length = shader->info.clip_distance_array_size +
> -                                    shader->info.cull_distance_array_size;
>                         if (stage == MESA_SHADER_VERTEX) {
>                                 ctx->shader_info->vs.outinfo.clip_dist_mask = (1 << shader->info.clip_distance_array_size) - 1;
>                                 ctx->shader_info->vs.outinfo.cull_dist_mask = (1 << shader->info.cull_distance_array_size) - 1;
> @@ -2254,10 +2252,6 @@ scan_shader_output_decl(struct radv_shader_context *ctx,
>                                 ctx->shader_info->tes.outinfo.cull_dist_mask <<= shader->info.clip_distance_array_size;
>                         }
>
> -                       if (length > 4)
> -                               attrib_count = 2;
> -                       else
> -                               attrib_count = 1;
>                         mask_attribs = 1ull << idx;
>                 }
>         }
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list