[Mesa-dev] [PATCH] radv: don't expose linear depth surfaces on SI/CIK/VI either.

Dave Airlie airlied at gmail.com
Fri Aug 31 05:56:33 UTC 2018


From: Dave Airlie <airlied at redhat.com>

ac_surface.c: gfx6_compute_surface says
/* DB doesn't support linear layouts. */

Now if we expose linear depth and create a linear depth image
and use CmdCopyImage to copy into it, we can't map the underlying
memory and read it linearly which I think should work.
---
 src/amd/vulkan/radv_formats.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index 6253c27b95d..e1b4b5e830f 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -645,9 +645,8 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical
 			if (radv_is_filter_minmax_format_supported(format))
 				 tiled |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_MINMAX_BIT_EXT;
 
-			/* GFX9 doesn't support linear depth surfaces */
-			if (physical_device->rad_info.chip_class >= GFX9)
-				linear = 0;
+			/* Don't support linear depth surfaces */
+			linear = 0;
 		}
 	} else {
 		bool linear_sampling;
-- 
2.17.1



More information about the mesa-dev mailing list