[Mesa-dev] GitLab merge requests, discussion summary - Re: [PATCH] docs: Document optional GitLab code review process

[Eric Anholt]

Jordan Justen <jordan.l.justen at intel.com> writes:

> Lots of discussion here. :) I hoped to just dip our toes into the
> merge request stream, but the consensus is clearly against my idea. Oh
> well. :)
>
> Here's what I gathered from the discussion:
>
> == Keep email, allow duplicate MR, my idea ==
>
> I don't think anyone else was in favor of this. Several were against
> it.
>
> == NACK merge requests altogether ==
>
> I did not see this, so that seems promising for merge requests. :) I
> guess no one strongly disagrees with trying merge requests.
>
> == Allow submitter (or driver) to choose to email or MR, but not both ==
>
> Several seemed to argue that this could be a good next step. But, in
> all those cases, I think they wanted to use merge requests going
> forward.
>
> It was mentioned that vc4 has moved to github in order to allow github
> pull requests to be used.

FWIW I moved to github because it allows contributors to use a familiar
process (no new logins!  non-bugzilla bug tracking!).  It was a success
except:

- I can't merge their PRs directly, I have to manually merge them to
  master anyway.

- Because issues and wiki are on github, they expect that they should be
  building and testing off of some branch in my repo, instead of Mesa
  master.  This does not go well.

I would love to solve both of those problems by having gitlab issues and
MRs enabled on the main repo.

> My opinion would be to try to move a bit slower and allow the
> submitter/project to choose for a trial period. (Dylan and Daniel seem
> to think this could be really frustrating for devs though.) But, if
> everyone seems to think it's reasonable to try to jump straight to
> using merge requests exclusively, I can type that version up...

I vote for this.  I suspect existing devs will be more interested in
switching once they have some good experiences with the new model
(that's how I was, at least).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181203/7c49447e/attachment.sig>