[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

Jordan Justen jordan.l.justen at intel.com
Thu Dec 6 01:05:29 UTC 2018


On 2018-12-05 15:44:18, Jason Ekstrand wrote:
> On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen <jordan.l.justen at intel.com>
> wrote:
> > -<h2 id="mailing">Mailing Patches</h2>
> > +<h2 id="submit">Submitting Patches</h2>
> >
> >  <p>
> > -Patches should be sent to the mesa-dev mailing list for review:
> > +Patches may be submitted to the Mesa project by
> > +<a href="#mailing">email</a> or with a
> > +GitLab <a href="#merge-request">merge request</a>. To prevent
> > +duplicate code review, only use one method to submit your changes.
> > +</p>
> >
> 
> Do we want to require a cover-letter to be sent to the ML?  Ideally, we'd
> just have a bot that makes one every time someone submits a MR and sends it
> to the list.  Maybe someone just needs to write that bot.
> 
> > +
> > +<h3 id="mailing">Mailing Patches</h3>
> > +
> > +<p>
> > +Patches may be sent to the mesa-dev mailing list for review:
> >  <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">
> >  mesa-dev at lists.freedesktop.org</a>.
> >  When submitting a patch make sure to use
> > @@ -217,8 +228,63 @@ disabled before sending your patches. (Note that you
> > may need to contact
> >  your email administrator for this.)
> >  </p>
> >
> > +<h3 id="merge-request">GitLab Merge Requests</h3>
> > +
> > +<p>
> > +  <a href="https://gitlab.freedesktop.org/mesa/mesa">GitLab</a> Merge
> > +  Requests (MR) can also be used to submit patches for Mesa.
> > +</p>
> > +
> > +<p>
> > +  If the MR may have interest for most of the Mesa community, you can
> > +  send an email to the mesa-dev email list including a link to the MR.
> > +  Don't send the patch to mesa-dev, just the MR link.

Regarding the cover-letter, I put in this weasel worded sentence.
Should it instead say this is required and that it should be a git
format-patch generated cover letter?

Or, should we drop it entirely and assume we'll get an automated way
to send an email to the list whenever a new MR is opened?

Relatedly, I think it might be possible to enable an irc channel to be
notified about pushes and MR's. Not sure if it'd be a good idea, or
maybe too noisy.

-Jordan


More information about the mesa-dev mailing list