[Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

[Eric Engestrom]

On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote:
> Under what circumstances would tegra have a vdpau implementation?

I don't know about that, but this patch brings meson on par with
autotools. Are you saying autotools was wrong and it should be removed
there instead?

FtR, src/gallium/targets/vdpau/Makefile.am includes
src/gallium/drivers/tegra/Automake.inc which adds tegra to the
TARGET_DRIVERS, which in turn produces libvdpau_tegra.so

If this was wrong, then that include on line 60 of
src/gallium/targets/vdpau/Makefile.am should be removed.

This line was added by Thierry Reding (cc'ed) when he first introduced
tegra support in 1755f608f5201e0a23f00 "tegra: Initial support".

> On Thu, Dec 6, 2018 at 11:57 AM Eric Engestrom <eric.engestrom at intel.com> wrote:
> >
> > From: Igor Gnatenko <i.gnatenko.brain at gmail.com>
> >
> > Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker"
> > Cc: Dylan Baker <dylan at pnwbakers.com>
> > ---
> >  src/gallium/targets/vdpau/meson.build | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/targets/vdpau/meson.build b/src/gallium/targets/vdpau/meson.build
> > index 005cf642498d68a0b395..0c09b2b811429b5688b8 100644
> > --- a/src/gallium/targets/vdpau/meson.build
> > +++ b/src/gallium/targets/vdpau/meson.build
> > @@ -51,13 +51,14 @@ libvdpau_gallium = shared_library(
> >      libpipe_loader_static, libws_null, libwsw, libswdri, libswkmsdri,
> >    ],
> >    dependencies : [
> > -    dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau,
> > +    dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, driver_tegra,
> >    ],
> >    link_depends : vdpau_link_depends,
> >  )
> >  foreach d : [[with_gallium_r300, 'r300'],
> >               [with_gallium_r600, 'r600'],
> >               [with_gallium_radeonsi, 'radeonsi'],
> > +             [with_gallium_tegra, 'tegra'],
> >               [with_gallium_nouveau, 'nouveau']]
> >    if d[0]
> >      vdpau_drivers += 'libvdpau_ at 0@.so.1.0.0'.format(d[1])
> > --
> > Cheers,
> >   Eric
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev