[Mesa-dev] [PATCH 08/12] virgl: make transfer code with PIPE_BUFFER targets

Gurchetan Singh gurchetansingh at chromium.org
Fri Dec 7 01:19:29 UTC 2018


util_format_get_blocksize returns 1 for R8 formats (all
PIPE_BUFFERs are R8).
---
 src/gallium/drivers/virgl/virgl_resource.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/virgl/virgl_resource.c b/src/gallium/drivers/virgl/virgl_resource.c
index ccbb67889e..a0b28e1d02 100644
--- a/src/gallium/drivers/virgl/virgl_resource.c
+++ b/src/gallium/drivers/virgl/virgl_resource.c
@@ -171,8 +171,10 @@ virgl_resource_create_transfer(struct pipe_context *ctx,
    }
    else if (pres->target == PIPE_TEXTURE_1D_ARRAY) {
       offset += box->z * metadata->stride[level];
-   }
-   else {
+      assert(box->y == 0);
+   } else if (pres->target == PIPE_BUFFER) {
+      assert(box->y == 0 && box->z == 0);
+   } else {
       assert(box->z == 0);
    }
 
-- 
2.18.1



More information about the mesa-dev mailing list