[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

Daniel Stone daniel at fooishbar.org
Fri Dec 7 20:24:08 UTC 2018


Hi,

On Sat, 8 Dec 2018 at 05:15, Eric Engestrom <eric.engestrom at intel.com> wrote:
> On Friday, 2018-12-07 10:19:23 +0100, Erik Faye-Lund wrote:
> > Automated emails (and perhaps IRC bot) would be really nice.
>
> Agreed. Email would be great to help with the transition.
> There's work currently being done on GitLab to allow for mailing lists
> to be notified; this should cover 'new MR' as well.
> If we need this feature before GitLab is done, it should be possible to
> write a bot using the webhooks, just needs someone to take the time to
> do it :)
>
> For IRC, there's already some integration, but it's limited to notifying
> about git pushes for now:
> https://docs.gitlab.com/ee/user/project/integrations/irker.html
>
> There's an open issue about adding more events, but it hasn't seen much
> activity:
> https://gitlab.com/gitlab-org/gitlab-ce/issues/7965

Wayland uses a couple of eventd plugins chained together:
https://github.com/sardemff7/git-eventc

That notifies the channel when issues and MRs are opened or closed and
on push as well, including things like the labels. It's been pretty
useful so far.

> > Even better if it could be hooked up to scripts/get_reviewer.pl, and
> > automatically CC "the right people".
>
> Side note, I've been rewriting that script, although I need to send v2
> out at some point:
> https://patchwork.freedesktop.org/patch/226256/
>
> I would be trivial to hook that into a bot we'd write, but I don't think
> GitLab has support for something like this. I just opened an issue about
> adding support directly in GitLab:
> https://gitlab.com/gitlab-org/gitlab-ce/issues/55035

This already exists, as an EE-only feature called 'code owners':
https://docs.gitlab.com/ee/user/project/code_owners.html
https://gitlab.com/gitlab-org/gitlab-ee/issues/1012

Cheers,
Daniel


More information about the mesa-dev mailing list