[Mesa-dev] [RFC PATCH 01/13] spirv/nir: update Xfb decoration comment

Alejandro PiƱeiro apinheiro at igalia.com
Sat Dec 8 11:48:09 UTC 2018


Now Vulkan radv driver, and ARB_gl_spirv implementation supports
transform feedback. Having said so, those decorations are handled
elsewhere.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
---
 src/compiler/spirv/spirv_to_nir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index 4e1ffc3fcbe..d1a86210656 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -775,7 +775,7 @@ struct_member_decoration_cb(struct vtn_builder *b,
 
    case SpvDecorationXfbBuffer:
    case SpvDecorationXfbStride:
-      vtn_warn("Vulkan does not have transform feedback");
+      /* Handled at vtn_variables.c, apply_var_decoration */
       break;
 
    case SpvDecorationCPacked:
-- 
2.19.1



More information about the mesa-dev mailing list