[Mesa-dev] [Bug 108974] make check DispatchSanity_test regression

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Dec 10 23:22:43 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=108974

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Kristian Høgsberg <krh at bitplanet.net> ---
commit c0de7c21a352dc5ea556df0397d0b34559bb89c2
Author: Kristian H. Kristensen <hoegsberg at gmail.com>
Date:   Mon Dec 10 18:14:34 2018 +0000

    glapi: fixup EXT_multisampled_render_to_texture dispatch

    There's a few missing and convoluted bits:

     - FramebufferTexture2DMultisampleEXT
    Missing sanity check, should be desktop="false"

     - RenderbufferStorageMultisampleEXT
    Missing sanity check, is aliased to RenderbufferStorageMultisample.
    Thus it's set only when desktop GL or GLES2 v3.0+, while the extension
    is GLES2 2.0+.

    If we flip the aliasing we'll break indirect GLX, so loosen the version
    to 2.0. Not perfect, yet this is the most sane thing I could think of.

    v2: [Emil] Fixup RenderbufferStorageMultisampleEXT, commmit message

    Cc: Kristian H. Kristensen <hoegsberg at gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108974
    Fixes: 1b331ae505e ("mesa: Add core support for
EXT_multisampled_render_to_texture{,2}")
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181210/d3748201/attachment.html>


More information about the mesa-dev mailing list