[Mesa-dev] [PATCH 03/15] anv: make anv_get_image_format_features public

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Dec 11 13:11:06 UTC 2018


On 27/11/2018 10:53, Tapani Pälli wrote:
> This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID.
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>


> ---
>   src/intel/vulkan/anv_formats.c | 22 +++++++++++-----------
>   src/intel/vulkan/anv_private.h |  5 +++++
>   2 files changed, 16 insertions(+), 11 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
> index d3a7c2be85c..aa2093f7f15 100644
> --- a/src/intel/vulkan/anv_formats.c
> +++ b/src/intel/vulkan/anv_formats.c
> @@ -492,11 +492,11 @@ anv_get_format_plane(const struct gen_device_info *devinfo, VkFormat vk_format,
>   
>   // Format capabilities
>   
> -static VkFormatFeatureFlags
> -get_image_format_features(const struct gen_device_info *devinfo,
> -                          VkFormat vk_format,
> -                          const struct anv_format *anv_format,
> -                          VkImageTiling vk_tiling)
> +VkFormatFeatureFlags
> +anv_get_image_format_features(const struct gen_device_info *devinfo,
> +                              VkFormat vk_format,
> +                              const struct anv_format *anv_format,
> +                              VkImageTiling vk_tiling)
>   {
>      VkFormatFeatureFlags flags = 0;
>   
> @@ -743,11 +743,11 @@ void anv_GetPhysicalDeviceFormatProperties(
>   
>      *pFormatProperties = (VkFormatProperties) {
>         .linearTilingFeatures =
> -         get_image_format_features(devinfo, vk_format, anv_format,
> -                                   VK_IMAGE_TILING_LINEAR),
> +         anv_get_image_format_features(devinfo, vk_format, anv_format,
> +                                       VK_IMAGE_TILING_LINEAR),
>         .optimalTilingFeatures =
> -         get_image_format_features(devinfo, vk_format, anv_format,
> -                                   VK_IMAGE_TILING_OPTIMAL),
> +         anv_get_image_format_features(devinfo, vk_format, anv_format,
> +                                       VK_IMAGE_TILING_OPTIMAL),
>         .bufferFeatures =
>            get_buffer_format_features(devinfo, vk_format, anv_format),
>      };
> @@ -794,8 +794,8 @@ anv_get_image_format_properties(
>      if (format == NULL)
>         goto unsupported;
>   
> -   format_feature_flags = get_image_format_features(devinfo, info->format,
> -                                                    format, info->tiling);
> +   format_feature_flags = anv_get_image_format_features(devinfo, info->format,
> +                                                        format, info->tiling);
>   
>      switch (info->type) {
>      default:
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index cfe16d2f0d2..c855f9e4b0d 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -3121,6 +3121,11 @@ anv_sanitize_image_offset(const VkImageType imageType,
>      }
>   }
>   
> +VkFormatFeatureFlags
> +anv_get_image_format_features(const struct gen_device_info *devinfo,
> +                              VkFormat vk_format,
> +                              const struct anv_format *anv_format,
> +                              VkImageTiling vk_tiling);
>   
>   void anv_fill_buffer_surface_state(struct anv_device *device,
>                                      struct anv_state state,




More information about the mesa-dev mailing list