[Mesa-dev] [PATCH 2/2] glx: make xf86vidmode mandatory for direct rendering

[Jon Turney]

On 16/11/2018 15:12, Eric Engestrom wrote:
> On Friday, 2018-11-16 13:59:01 +0000, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> Currently we detect the module and if missing, the glXGetMsc* API is
>> effectively a stub, always returning false.
>>
>> This is what effectively has been happening with our meson build :-(
> 
> Oops... you're right: s/HAVE_XF86VIDMODE/XF86VIDMODE/ typo which was never
> caught because dep_xxf86vm was missing from libglx's dependencies :/


> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> Fixes: a47c525f3281a2753180e "meson: build glx"
> 
>>
>> Thus users have no chance of using it - they cannot even distinguish
>> if the failure is due to a misconfigured build.
>>
>> There's no reason for keeping xf86vidmode optional - it has been
>> available in all distributions for years.
> 
> If you have an actual year number on that it might be worth writing it
> down in the commit message; not important if you don't.

Sadly, this turns out to be not quite true.

I've sent patches to revert and fix this the other way.