[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

Erik Faye-Lund erik.faye-lund at collabora.com
Wed Dec 12 10:20:20 UTC 2018


On Tue, 2018-12-11 at 18:06 -0600, Jason Ekstrand wrote:
> Ping?
> 
> I see about 5 acks/reviews, 3 of which are from Intel which doesn't
> exactly seem like overwhelming consensus.  However, we also haven't
> had any debate in a while.

Oh, absolutely, I'm very much a supporter of tring this out! With or
without any bots or anything :)

Acked-by: Erik Faye-Lund <erik.faye-lund at collabora.com>

> I know some people are somewhat skeptical as to how well it will work
> but they won't be able to see until we actually start experimenting
> with it which we can't do until we allow MRs.  Personally, I say we
> should just turn on the option in GitLab and people can start playing
> with it and see how it goes.  We can always decide later that it was
> a terrible idea and move all active MRs back to the list.
> 
> --Jason
> 
> On Fri, Dec 7, 2018 at 2:24 PM Daniel Stone <daniel at fooishbar.org>
> wrote:
> > Hi,
> > 
> > On Sat, 8 Dec 2018 at 05:15, Eric Engestrom <
> > eric.engestrom at intel.com> wrote:
> > > On Friday, 2018-12-07 10:19:23 +0100, Erik Faye-Lund wrote:
> > > > Automated emails (and perhaps IRC bot) would be really nice.
> > >
> > > Agreed. Email would be great to help with the transition.
> > > There's work currently being done on GitLab to allow for mailing
> > lists
> > > to be notified; this should cover 'new MR' as well.
> > > If we need this feature before GitLab is done, it should be
> > possible to
> > > write a bot using the webhooks, just needs someone to take the
> > time to
> > > do it :)
> > >
> > > For IRC, there's already some integration, but it's limited to
> > notifying
> > > about git pushes for now:
> > > https://docs.gitlab.com/ee/user/project/integrations/irker.html
> > >
> > > There's an open issue about adding more events, but it hasn't
> > seen much
> > > activity:
> > > https://gitlab.com/gitlab-org/gitlab-ce/issues/7965
> > 
> > Wayland uses a couple of eventd plugins chained together:
> > https://github.com/sardemff7/git-eventc
> > 
> > That notifies the channel when issues and MRs are opened or closed
> > and
> > on push as well, including things like the labels. It's been pretty
> > useful so far.
> > 
> > > > Even better if it could be hooked up to
> > scripts/get_reviewer.pl, and
> > > > automatically CC "the right people".
> > >
> > > Side note, I've been rewriting that script, although I need to
> > send v2
> > > out at some point:
> > > https://patchwork.freedesktop.org/patch/226256/
> > >
> > > I would be trivial to hook that into a bot we'd write, but I
> > don't think
> > > GitLab has support for something like this. I just opened an
> > issue about
> > > adding support directly in GitLab:
> > > https://gitlab.com/gitlab-org/gitlab-ce/issues/55035
> > 
> > This already exists, as an EE-only feature called 'code owners':
> > https://docs.gitlab.com/ee/user/project/code_owners.html
> > https://gitlab.com/gitlab-org/gitlab-ee/issues/1012
> > 
> > Cheers,
> > Daniel
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list