[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)
Ilia Mirkin
imirkin at alum.mit.edu
Thu Dec 13 15:56:33 UTC 2018
On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
> >
> > Personally, I will continue to use the list, at least for a simplicity
> > point of view. I'm not sure if using a new tool will improve quality and
> > code review process.
> >
> > Though, if the majority reports that is really nice to use, I will
> > probably change my mind. Not a strong reject.
>
> I agree. We've been using the MR interface for xf86-video-amdgpu and
> I find it awkward compared to the mailing list. Maybe it just takes
> getting used to. I also feel less inclined to do drive by patch
> review if I have to explicitly delve into the browser to look at the
> outstanding MRs. Over email, sometimes I see a patch set in my in box
> that piques my interest and I find some time to review it when I might
> not have otherwise if the bar were higher.
FWIW I also do a lot of drive-by reviews. Perhaps those aren't
valuable -- dunno. Either way, if it's not in email, I won't end up
seeing it.
-ilia
More information about the mesa-dev
mailing list