[Mesa-dev] last call for autotools

[Rob Clark]

On Thu, Dec 13, 2018 at 2:41 PM Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> On Wed, Dec 12, 2018 at 2:52 PM Rob Clark <robdclark at gmail.com> wrote:
>>
>> On Wed, Dec 12, 2018 at 3:45 PM Marek Olšák <maraeo at gmail.com> wrote:
>> >
>> > On Wed, Dec 12, 2018 at 3:37 PM Rob Clark <robdclark at gmail.com> wrote:
>> >>
>> >> On Wed, Dec 12, 2018 at 3:13 PM Bas Nieuwenhuizen
>> >> <bas at basnieuwenhuizen.nl> wrote:
>> >> >
>> >> > On Wed, Dec 12, 2018 at 8:59 PM Marek Olšák <maraeo at gmail.com> wrote:
>> >> > >
>> >> > > There are 2 issues with meson:
>> >> > > * -DDEBUG is not present in debugoptimized builds.
>> >> >
>> >> > Do people expect -DDEBUG for debugoptimized? I would think that debug
>> >> > optimized would be an optimized build with debug symbols, but not
>> >> > expensive checks & asserts, which would match the current
>> >> > debugoptimized build?
>> >>
>> >> please, no -DDEBUG for debugoptimized.. I use that when I want debug
>> >> syms but not (for example) nir_validate and other expensive checks.
>> >
>> >
>> > If nir_validate is so bad, perhaps it shouldn't be run at all. If you work on NIR and it's not important for you to run nir_validate, perhaps it shouldn't be run at all. It doesn't have anything to do with build systems.
>> >
>>
>> I do actually want it enabled when I piglit/deqp..  for which I use
>> debug builds.  But I don't want it if I'm profiling or valgrinding,
>> where I use debugoptimized..
>
>
> IMO, you shouldn't do any profiling with any build that has the world "debug" in the name.  What it sounds like you want is a meson equivalent of CMake's RelWithDebugInfo which meson doesn't currently have.

this is kinda what I expect debugoptimzied to be.  And in fact we only
set -DDEBUG for 'debug' and not 'debugoptimized' if I'm reading
meson.build correctly..

BR,
-R