[Mesa-dev] [PATCH 1/4] nir: add if opt opt_if_loop_last_continue()

[Timothy Arceri]

On 13/12/18 8:10 pm, Samuel Pitoiset wrote:
> This introduces crashes for
> 
> dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_frag 
> 
> dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_geom 
> 
> dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_tessc 
> 
> dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_tesse 
> 
> dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_vert 
> 
> 
> Test case 
> 'dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_frag'.. 
> 
> deqp-vk: nir/nir_control_flow.c:553: stitch_blocks: Assertion 
> `exec_list_is_empty(&after->instr_list)' failed.
> Aborted (core dumped)
> 
> Did you run CTS?

Yes I'd run it through Intels CI countless times. I've sent a fix, seems 
the ordering of optimisations on RADV vs intels drivers causes us to 
trip up on this one were the other drivers did not.