[Mesa-dev] [PATCH v2 09/24] mapi/new: sort by slot number

Erik Faye-Lund erik.faye-lund at collabora.com
Fri Dec 14 14:38:17 UTC 2018


I assume this will be kicked out of the branch before we merge? I mean,
either works, it just seems a bit pointless to keep patches to aid
comparisons in our tree.

On Fri, 2018-12-14 at 14:04 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Makes it easier to compare the newly generated header against the old
> one. Will be reverted after the transition.
> ---
>  src/mapi/new/genCommon.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mapi/new/genCommon.py b/src/mapi/new/genCommon.py
> index b0925d80151..ec48d522c05 100644
> --- a/src/mapi/new/genCommon.py
> +++ b/src/mapi/new/genCommon.py
> @@ -74,6 +74,9 @@ def getFunctionsFromRoots(roots):
>      for i in range(len(functions)):
>          functions[i] = functions[i]._replace(slot=i)
>  
> +    # Sort the function list by slot.... to simplify the diff
> +    functions = sorted(functions, key=lambda f: f.slot)
> +
>      return functions
>  
>  def getExportNamesFromRoots(target, roots):



More information about the mesa-dev mailing list