[Mesa-dev] [PATCH 04/18] glx: meson: drop includes from a link-only library

Dylan Baker dylan at pnwbakers.com
Fri Dec 14 17:14:07 UTC 2018


Quoting Emil Velikov (2018-12-13 08:05:53)
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> When producing the final libGL.so/libGLX_mesa.so we only link the local
> static helper lib (libglx). Thus there's no reason for the includes.
> 
> Fixes: a47c525f328 ("meson: build glx")
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/glx/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/glx/meson.build b/src/glx/meson.build
> index 898ed1f5826..4eb2e0a21d2 100644
> --- a/src/glx/meson.build
> +++ b/src/glx/meson.build
> @@ -155,7 +155,6 @@ libglx = static_library(
>  libgl = shared_library(
>    gl_lib_name,
>    [],
> -  include_directories : [inc_common, inc_glapi, inc_loader, inc_gl_internal],
>    link_with : [libglapi_static, libglapi],
>    link_whole : libglx,
>    link_args : [ld_args_bsymbolic, ld_args_gc_sections, extra_ld_args_libgl],
> -- 
> 2.19.2
> 

ah yes, this is an artifact from other refactors, good catch:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181214/4dda6367/attachment.sig>


More information about the mesa-dev mailing list