[Mesa-dev] [PATCH 01/18] meson: don't require glx/egl/gbm with gallium drivers

[Dylan Baker]

Quoting Emil Velikov (2018-12-13 08:05:50)
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> The gallium drivers do not require a DRI loader. Drop the artificial
> and unnecessary restriction.
> 
> Fixes: af9d276134d ("meson: build libmesa_gallium")
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> There are a few use cases:
> 
>  - building a gallium state-tracker, say opencl in st/clover, without
> having to build the dri one (st/dri)
> Use case: shipping only a opencl/omx/va driver.
> 
>  - building dri loader without an actual DRI driver.
> Use case: working/updating libGL/libGLX_mesa and egl/gbm equivalents.
> 
> This patch should address the former, although the latter seems figgly
> to fix from a quick look. Input and patches will be appreciated.
> ---
>  meson.build | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index db2d27d2459..2aa2794f971 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -387,9 +387,9 @@ endif
>  if with_any_vk and (with_platform_x11 and not with_dri3)
>    error('Vulkan drivers require dri3 for X11 support')
>  endif
> -if with_dri or with_gallium
> -  if with_glx == 'disabled' and not with_egl and not with_platform_haiku
> -    error('building dri or gallium drivers require at least one window system')
> +if with_dri
> +  if with_glx == 'disabled' and not with_egl and not with_gbm
> +    error('building dri drivers require at least one windowing system')
>    endif
>  endif
>  
> -- 
> 2.19.2
> 

I'm not super convinced that building the loader and drivers separately is a
good idea, but building just clover (or media I guess) does seem like a real use
case.

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181214/4a2af8e5/attachment.sig>