[Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

[Jon Turney]

On 14/12/2018 15:15, Emil Velikov wrote:
> On Fri, 14 Dec 2018 at 14:56, Jon Turney <jon.turney at dronecode.org.uk> wrote:
>>
>> Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical
>> (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs)
>>
>> Include <sys/time.h> again, as functions prototyped by it are used in
>> the GLX_USE_WINDOWSGL path.
>>
>> Make the include guard around the __glxGetMscRate() definition match the
>> one at it's declaration again, as it's referenced from dri_common.c
>> which is built for GLX_USE_WINDOWSGL.
>>
>> Cc: Emil Velikov <emil.velikov at collabora.com>
>> Fixes: a95ec138 ("glx: mandate xf86vidmode only for "drm" dri platforms")
>> Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Jon, when you have some time, can you please write a Travis config for Cygwin.
> This way we can do some basic checks a bit easier.

Yeah, that would be a good idea.

I've posted an updated version of my patchset to add a cygwin build for 
appveyor.

Doing this on travis will be challenging, especially to run the tests.

> If/when we move to gitlab CI we can simply copy it over ;-)

(It is apparently now possible to use appveyor as a CI provider for a 
self-hosted gitlab instance (see [1]), but I've no idea how to set that up)

[1] https://github.com/appveyor/ci/issues/711