[Mesa-dev] PSA: Please send MRs to the mailing list

[Jason Ekstrand]

On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand <jason at jlekstrand.net> wrote:

> On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt <eric at anholt.net> wrote:
>
>> Jason Ekstrand <jason at jlekstrand.net> writes:
>>
>> > I don't know if it was actually in the doc that Jordan wrote up but it's
>> > courteous of you to send a quick e-mail to the mailing list when you
>> create
>> > a new MR so that people who aren't regularly trolling the list of MRs
>> are
>> > at least aware that it exists.  Of the 20 MRs that have been posted so
>> far,
>> > I think I'm the only one doing this.  I'm a big fan of MRs but I also
>> don't
>> > want us MR fans to anger the list. :-)
>>
>> The conclusion of the MR discussion was that notifying the list was
>> optional, I thought.
>>
>> +<p>
>> +  If the MR may have interest for most of the Mesa community, you can
>> +  send an email to the mesa-dev email list including a link to the MR.
>> +  Don't send the patch to mesa-dev, just the MR link.
>> +</p>
>>
>
> Yeah, I think the problem is that "interest for most of the Mesa
> community" is very vague.  What it really should mean is "unless you're
> very sure that everyone who cares is skimming through MRs".  I've seen
> multiple MRs which touch on st/mesa stuff in reasonably generic ways and
> I'm pretty sure the radeon devs and other gallium types were some of the
> less excited about MRs.
>
>
>> The MR process is heavier-weight than I hoped for, given that we're
>> currently requiring rebasing tags into commit messages.  I don't want to
>> add more overhead to it if we don't have to.
>>
>
> I agree.  I think the real solution here is that we just need a bot.
>

I took a swing at this.  This python script will do the trick if we can
find somewhere to host it and harden it a bit against being a spam-magnet:

https://paste.fedoraproject.org/paste/EGGpnxNNWEmadt0fWJEfGg

It's really not all that hard, it's just a bit annoying that GitLab
requires you to run server-side scripting in a web server in order to
implement a simple hook.

Unfortunately, Ilia's request for a diffstat is easier said than done.  In
order to do that, the script would have to actually pull the repo and run
git commands.  It could be done but would be a *lot* more work.  I'm not
going to attempt that today nor do I really want to get stuck maintaining a
python git hook library. :-P

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181217/42fcc1d4/attachment.html>