[Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

[Kyle Brenneman]

On 12/14/2018 07:04 AM, Emil Velikov wrote:
> There is no need for the noop functions, the public_stubs and
> public_entries table or table size defines. Remove those.
>
> Pretty much all of this is applicable to GLVND, although it
> requires preparatory work.
>
> v2:
>   - python style fixes (Dylan)
>   - use "gldispatch" instead of not "glesv1" "glesv2"
>   - remove the public_entries table/array (Erik)
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>   src/mapi/new/gen_gldispatch_mapi.py | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/mapi/new/gen_gldispatch_mapi.py b/src/mapi/new/gen_gldispatch_mapi.py
> index 959d8798f5c..cc0e286e221 100755
> --- a/src/mapi/new/gen_gldispatch_mapi.py
> +++ b/src/mapi/new/gen_gldispatch_mapi.py
> @@ -63,11 +63,13 @@ typedef void (APIENTRY  *GLDEBUGPROCKHR)(GLenum source,GLenum type,GLuint id,GLe
>   """.lstrip("\n"))
>   
>       print(generate_defines(functions))
> -    print(generate_table(functions, allFunctions))
> -    print(generate_noop_array(functions))
> -    print(generate_public_stubs(functions))
> +    if target in "gldispatch":
This should be an "==", not "in". The in operator would do a substring 
search.
> +        print(generate_table(functions, allFunctions))
> +        print(generate_noop_array(functions))
> +        print(generate_public_stubs(functions))
>       print(generate_public_entries(functions))
> -    print(generate_public_entries_table(functions))
> +    if target in "gldispatch":
> +        print(generate_public_entries_table(functions))
>       print(generate_undef_public_entries())
>       print(generate_stub_asm_gcc(functions))
>