[Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

[Dylan Baker]

Quoting Emil Velikov (2018-12-18 02:33:56)
> On Mon, 17 Dec 2018 at 19:44, Dylan Baker <dylan at pnwbakers.com> wrote:
> >
> > Quoting Emil Velikov (2018-12-17 10:58:11)
> > > On Fri, 14 Dec 2018 at 17:13, Dylan Baker <dylan at pnwbakers.com> wrote:
> > > >
> > > > Quoting Emil Velikov (2018-12-13 08:05:52)
> > > > > From: Emil Velikov <emil.velikov at collabora.com>
> > > > >
> > > > > The library is the dri capable one, push the check src/meson.build,
> > > > > instead of the current partial handling in src/glx/meson.build.
> > > > >
> > > > > Fixes: a47c525f328 ("meson: build glx")
> > > >
> > > > This is just a refactor, the Fixes: is unnecessary. More on that below
> > > >
> > > If I'm reading things correctly, building with -Dglx=xlib/gallium-xlib
> > > -Dshared-glapi -Denable-tests - will attempt to build the tests in
> > > src/glx/tests/.
> > > Which is something that shouldn't happen IMHO.
> >
> > Wait, why shouldn't they run? The tests pass (at least with the gallium-xlib
> > glx), and running tests seems useful.
> >
> Fully agree running tests is useful and welcome.
> 
> The tests flex the -Dglx=dri code in src/glx/. As-is it's rather
> confusing, misleading even, to request one thing then run tests for
> something that looks the same but isn't.
> Silly analogy - running ANV tests, when -Dvulkan-drivers=amd is used.
> 
> Hope this is clear - not sure if the coffee has kicked in ;-)
> -Emil

Sorry, I meant to respond yesterday. Ian explained why these tests are only
useful if building DRI based GLX.

Maybe make the commit message something like:
"meson: Ensure tests for dri based glx are only built when dri based glx is enabled"
or something like that? I'll leave it up to you what you think is best. As long
as you note that the real functional change is not building tests when we don't
want/need them.

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181218/b8783aab/attachment.sig>