[Mesa-dev] [PATCH] gallivm: don't use pavg.b intrinsic on llvm >= 6.0

Michel Dänzer michel at daenzer.net
Fri Dec 21 10:31:36 UTC 2018


On 2018-12-21 1:25 a.m., sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
> 
> This intrinsic disppeared with llvm 6.0, using it ends up in segfaults
> (due to llvm issuing call to NULL address in the jited shaders).
> Add code doing the same thing as the autoupgrade code in llvm so it
> can be matched and replaced back with a pavgb.
> 
> While here, also improve lp_test_format, so it tests both with and without
> cache (as it was, it tested the cache versions only, whereas cache is
> actually disabled in llvmpipe, and in any case even with it enabled
> vertex and geometry shaders wouldn't use it). (Although at least for
> the unorm8 uncached fetch, the code is still quite different to what
> llvmpipe is using, since that would use unorm8x16 type, whereas
> the test code is using unorm8x4 type, hence disabling some intrinsic
> paths.)
> 
> Fixes: 6f4083143bb8c478ccfcaef034d183d89b471993

I'd suggest shortening the hash to ~12 characters and adding the
shortlog, but either way,

Tested-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list