[Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

[Jason Ekstrand]

This isn't quite true. Fast-clear without CCS compression (also known as 
CCS_D) is supported on gen9.  There is, however, a bug with blending and 
non-0/1 clear colors that we don't currently bother handling in anv. See also:

https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/mesa/drivers/dri/i965/intel_mipmap_tree.c#L2672

On December 21, 2018 06:26:31 Samuel Iglesias Gonsálvez 
<siglesias at igalia.com> wrote:

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108911
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>
> Lionel, I have doubts if this is only for gen9 or it should be gen9+.
> Can you confirm on gen10 if the sRGB bug is happening there and if this
> fixes it? (You would need to adapt the GEN_GEN == 9 to >=).
>
> src/intel/vulkan/genX_cmd_buffer.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c 
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 93b5269c6ba..cb08ef8df1e 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -324,6 +324,10 @@ color_attachment_compute_aux_usage(struct anv_device * 
> device,
>          break;
>       }
>
> +      /* Gen9 doesn't support fast clear on single-sampled SRGB buffers */
> +      if (GEN_GEN == 9 && isl_format_is_srgb(iview->planes[0].isl.format) 
> && iview->image->samples == 1)
> +         att_state->fast_clear = false;
> +
>       /* Potentially, we could do partial fast-clears but doing so has crazy
>        * alignment restrictions.  It's easier to just restrict to full size
>        * fast clears for now.
> --
> 2.19.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev