[Mesa-dev] [PATCH v2 2/2] etnaviv: annotate variables only used in debug build

[Christian Gmeiner]

Am Mi., 19. Dez. 2018 um 16:27 Uhr schrieb Lucas Stach <l.stach at pengutronix.de>:
>
> Some of the status variables in the compiler are only used in asserts
> and thus may be unused in release builds. Annotate them accordingly
> to avoid 'unused but set' warnings from the compiler.
>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

> ---
> v2: get rid of superfluous variable initialization
> ---
>  src/gallium/drivers/etnaviv/etnaviv_compiler.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c
> index bbc61a59fc67..ceca5b8af997 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_compiler.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_compiler.c
> @@ -477,8 +477,7 @@ static void
>  etna_compile_parse_declarations(struct etna_compile *c)
>  {
>     struct tgsi_parse_context ctx = { };
> -   unsigned status = TGSI_PARSE_OK;
> -   status = tgsi_parse_init(&ctx, c->tokens);
> +   MAYBE_UNUSED unsigned status = tgsi_parse_init(&ctx, c->tokens);
>     assert(status == TGSI_PARSE_OK);
>
>     while (!tgsi_parse_end_of_tokens(&ctx)) {
> @@ -530,8 +529,7 @@ static void
>  etna_compile_pass_check_usage(struct etna_compile *c)
>  {
>     struct tgsi_parse_context ctx = { };
> -   unsigned status = TGSI_PARSE_OK;
> -   status = tgsi_parse_init(&ctx, c->tokens);
> +   MAYBE_UNUSED unsigned status = tgsi_parse_init(&ctx, c->tokens);
>     assert(status == TGSI_PARSE_OK);
>
>     for (int idx = 0; idx < c->total_decls; ++idx) {
> @@ -662,8 +660,7 @@ etna_compile_pass_optimize_outputs(struct etna_compile *c)
>  {
>     struct tgsi_parse_context ctx = { };
>     int inst_idx = 0;
> -   unsigned status = TGSI_PARSE_OK;
> -   status = tgsi_parse_init(&ctx, c->tokens);
> +   MAYBE_UNUSED unsigned status = tgsi_parse_init(&ctx, c->tokens);
>     assert(status == TGSI_PARSE_OK);
>
>     while (!tgsi_parse_end_of_tokens(&ctx)) {
> @@ -1812,7 +1809,7 @@ static void
>  etna_compile_pass_generate_code(struct etna_compile *c)
>  {
>     struct tgsi_parse_context ctx = { };
> -   unsigned status = tgsi_parse_init(&ctx, c->tokens);
> +   MAYBE_UNUSED unsigned status = tgsi_parse_init(&ctx, c->tokens);
>     assert(status == TGSI_PARSE_OK);
>
>     int inst_idx = 0;
> --
> 2.19.1
>
> _______________________________________________
> etnaviv mailing list
> etnaviv at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/etnaviv



-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info