[Mesa-dev] [PATCH 1/2] egl/egldevice: Fix broken reference to dev->device without LIBDRM

[Mathias Fröhlich]

Good morning,

On Thursday, 27 December 2018 21:59:47 CET Ilia Mirkin wrote:
> I don't see this function used anywhere... it's not exported either.
> 
> It was added in dbb4457d9858fa977246aa5e9cabe83455022dfe by Emil as
> part of EGL_EXT_device_drm, but appears unused in that commit as well.
> 
> Emil - can this function just be removed perhaps?

Not Emil, so he probably knows more about that, especially the current state.

That function was introduced as a preparation for finally getting EGL_EXT_platform_device 
upported. For those final patches Emil wanted to clean up something in setting up a
software renderer when I pointed out a crash in the pbuffer code path.
I was always waiting for him to come up with that cleanup. I personally had
a 'workaround' that we could use to announce EGL_EXT_platform_device but not
offer any pbuffer config finally until that is cleaned up.

So, as of now the function is unused, but it will be used in the hopefully not so distant
future as I think we should have EGL_EXT_platform_device finally.

In Emils patches building on top, _eglGetDRMDeviceRenderNode is only called from
code paths guarded with HAVE_LIBDRM.

best

Mathias