[Mesa-dev] [PATCH] util/draw: draw_count not supported in util_draw_indirect()

Brian Paul brianp at vmware.com
Thu Feb 1 03:38:27 UTC 2018


So assert that and add a comment about it.

It would be a simple project for someone to add support for both
draw_count and the indirect_draw_count buffer.
---
 src/gallium/auxiliary/util/u_draw.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/gallium/auxiliary/util/u_draw.c b/src/gallium/auxiliary/util/u_draw.c
index a7590f7..5e6393d 100644
--- a/src/gallium/auxiliary/util/u_draw.c
+++ b/src/gallium/auxiliary/util/u_draw.c
@@ -138,8 +138,15 @@ util_draw_indirect(struct pipe_context *pipe,
    uint32_t *params;
    const unsigned num_params = info_in->index_size ? 5 : 4;
 
+   /*
+    * XXX we don't yet support the pipe_draw_indirect_info::draw_count
+    * value.  Nor do we support fetching the draw count from the
+    * pipe_draw_indirect_info::indirect_draw_count buffer.
+    */
    assert(info_in->indirect);
+   assert(info_in->indirect->draw_count == 1);
    assert(!info_in->count_from_stream_output);
+   assert(!info_in->indirect->indirect_draw_count);
 
    memcpy(&info, info_in, sizeof(info));
 
-- 
2.7.4



More information about the mesa-dev mailing list