[Mesa-dev] [PATCH v2] mesa: enable ASTC/ETC1 compressed 3D textures

[Juan A. Suarez Romero]

On Mon, 2018-01-29 at 16:25 -0800, Eric Anholt wrote:
> "Juan A. Suarez Romero" <jasuarez at igalia.com> writes:
> 
> > Enable these kind of 3D texture when proper extensions are available.
> > 
> > Fixes KHR-GLES2.texture_3d.* with these textures.
> > 
> > v2: add better clarification (Eric)
> > ---
> >  src/mesa/main/teximage.c | 31 ++++++++++++++++++++++++-------
> >  1 file changed, 24 insertions(+), 7 deletions(-)
> > 
> > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> > index e5f8bb0718f..56235898c66 100644
> > --- a/src/mesa/main/teximage.c
> > +++ b/src/mesa/main/teximage.c
> > @@ -1487,6 +1487,9 @@ _mesa_target_can_be_compressed(const struct gl_context *ctx, GLenum target,
> >        break;
> >     case GL_TEXTURE_3D:
> >        switch (layout) {
> > +      case MESA_FORMAT_LAYOUT_ETC1:
> > +         target_can_be_compresed = ctx->Extensions.OES_compressed_ETC1_RGB8_texture;
> > +         break;
> >        case MESA_FORMAT_LAYOUT_ETC2:
> >           /* See ETC2/EAC comment in case GL_TEXTURE_CUBE_MAP_ARRAY. */
> 
> OK, I took a look at the ETC2/EAC comment above, this time, and it looks
> like 3D textures are supposed to be not supported with ETC2 or ASTC
> according to table 8.17 in GLES 3.2.
> 
> This is looking more like a testcase bug to me.


Yes, you're right. This is similar to another patch I sent for review
and that turned out it was wrong for the same reason (both patches are
related with the same test).

So I withdraw this patch, and I'll send a fix for the testcase instead.

Thanks.


	J.A.