[Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

[Emil Velikov]

On 28 January 2018 at 14:24, Jon Turney <jon.turney at dronecode.org.uk> wrote:
> From: Dylan Baker <dylan at pnwbakers.com>
>
> ---
>  meson.build | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 824e3c46bc5..178743eddb1 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -642,7 +642,13 @@ if with_platform_android
>    pre_args += '-DHAVE_ANDROID_PLATFORM'
>  endif
>
> -prog_python2 = find_program('python2')
> +# Basically we can't trust Linux because one distro had decided that python
> +# should be python3. macOS doesn't have a python2 binary, however.
> +if build_machine.system() != 'darwin'
> +  prog_python2 = find_program('python2')
> +else
> +  prog_python2 = find_program('python')
> +endif

I think this is better suited in meson, thus everyone doesn't need to
reinvent the wheel.
Even if we're moving towards python2-free world ;-)

Until then, the patch looks reasonable.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil