[Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

Brian Paul brianp at vmware.com
Thu Feb 1 16:17:57 UTC 2018

On 02/01/2018 12:32 AM, Mathias.Froehlich at gmx.net wrote:
> From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
> Hi,
> Thanks for the review!
> This is the starting point to a patch series that I intent to feed.
> The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently
> happen at about any draw call.
> The series tries to separate out one of the depencies of the attribute
> aliasing code as a preparation of the above. It uses static const tables
> for the aliasing mapping. Also there is some cleanup to make use of
> these tables.
> v2: Use GLubyte instead of unsigned char
>      Remove _ from enum *_MAX values.
>      Change comment style.
>      Add Comments.
>      Put 2 empty lines between functions.
>      Change log message.
> This series was now rebased to v1 several times during the past weeks.
> Nevertheless the original v1 series past the rebases did not regress
> piglit quick on radeonsi, i965 and classical swrast. The v2 version
> incorporating the reiview comments was not yet run on piglit.
> Please review.

Looks good.

Reviewed-by: Brian Paul <brianp at vmware.com>

I don't remember, do you need me to push these for you?


More information about the mesa-dev mailing list