[Mesa-dev] [Bug 104908] Texture Compression Hint not converted to enum16

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=104908

            Bug ID: 104908
           Summary: Texture Compression Hint not converted to enum16
           Product: Mesa
           Version: git
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: medium
         Component: Mesa core
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: baldurk at baldurk.org
        QA Contact: mesa-dev at lists.freedesktop.org

In commit f96a69f916a "mesa: replace GLenum with GLenum16 in common structures
(v4)" it looks like Hints.TextureCompression was missed, it's still listed as
an int which leads to 0x11001100 being returned instead of 0x1100 as it reads
into the next value.

This diff fixes it for me, but there might be something else that needs to
update:

diff --git a/src/mesa/main/get_hash_params.py
b/src/mesa/main/get_hash_params.py
index e10282a156..df082af207 100644
--- a/src/mesa/main/get_hash_params.py
+++ b/src/mesa/main/get_hash_params.py
@@ -783,7 +783,7 @@ descriptor=[
   [ "EDGE_FLAG_ARRAY_COUNT_EXT", "CONST(0), NO_EXTRA" ],

 # GL_ARB_texture_compression
-  [ "TEXTURE_COMPRESSION_HINT_ARB", "CONTEXT_INT(Hint.TextureCompression),
NO_EXTRA" ],
+  [ "TEXTURE_COMPRESSION_HINT_ARB", "CONTEXT_ENUM16(Hint.TextureCompression),
NO_EXTRA" ],

 # GL_EXT_compiled_vertex_array
   [ "ARRAY_ELEMENT_LOCK_FIRST_EXT", "CONTEXT_INT(Array.LockFirst), NO_EXTRA"
],

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180201/5c166e2d/attachment.html>