[Mesa-dev] [PATCH] ac/nir: fix a crash in load_gs_input() on pre-GFX9 chips

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Fri Feb 2 18:09:04 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Feb 2, 2018 at 6:56 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Fixes: df1d5174fcc ("ac/nir: replace SI.buffer.load.dword with amdgcn.buffer.load")
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 0f7d6258acd..e0386429037 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -3074,6 +3074,9 @@ load_gs_input(struct ac_shader_abi *abi,
>                                                         ctx->ac.i32_0,
>                                                         vtx_offset, soffset,
>                                                         0, 1, 0, true, false);
> +
> +                       value[i] = LLVMBuildBitCast(ctx->builder, value[i],
> +                                                   type, "");
>                 }
>         }
>         result = ac_build_varying_gather_values(&ctx->ac, value, num_components, component);
> --
> 2.16.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list