[Mesa-dev] [PATCH 1/2] intel/compiler: fix first_component for 64-bit types on vertex inputs

[Iago Toral]

This series is still waiting for a review, any takers?

On Fri, 2018-01-19 at 09:17 +0100, Iago Toral Quiroga wrote:
> Divide it by two as we do for other stages. This is because the
> component layout qualifier is always in 32-bit units.
> 
> Fixes issues in a new CTS test (still WIP):
> KHR-GL45.enhanced_layouts.varying_double_components
> ---
>  src/intel/compiler/brw_fs_nir.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/intel/compiler/brw_fs_nir.cpp
> b/src/intel/compiler/brw_fs_nir.cpp
> index 0d775649303..7a6346a4b5d 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -2420,6 +2420,9 @@ fs_visitor::nir_emit_vs_intrinsic(const
> fs_builder &bld,
>        assert(const_offset && "Indirect input loads not allowed");
>        src = offset(src, bld, const_offset->u32[0]);
>  
> +      if (type_sz(type) == 8)
> +         first_component /= 2;
> +
>        for (unsigned j = 0; j < num_components; j++) {
>           bld.MOV(offset(dest, bld, j), offset(src, bld, j +
> first_component));
>        }