[Mesa-dev] [PATCH] i965: Enable disk shader cache by default

[Jason Ekstrand]

On Sat, Feb 3, 2018 at 2:58 PM, Jordan Justen <jordan.l.justen at intel.com>
wrote:

> On 2018-02-03 14:24:06, Jason Ekstrand wrote:
> > On February 3, 2018 13:59:40 Jordan Justen <jordan.l.justen at intel.com>
> wrote:
> >
> > > Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> > > Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
> > > ---
> > >  docs/relnotes/18.1.0.html                  | 1 +
> > >  src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 ---
> > >  2 files changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/docs/relnotes/18.1.0.html b/docs/relnotes/18.1.0.html
> > > index b8a0cd0d02c..0a5878ea41f 100644
> > > --- a/docs/relnotes/18.1.0.html
> > > +++ b/docs/relnotes/18.1.0.html
> > > @@ -46,6 +46,7 @@ Note: some of the new features are only available
> with
> > > certain drivers.
> > >  <ul>
> > >  <li>GL_EXT_semaphore on radeonsi</li>
> > >  <li>GL_EXT_semaphore_fd on radeonsi</li>
> > > +<li>Disk shader cache support for i965 enabled by default</li>
> > >  </ul>
> > >
> > >  <h2>Bug fixes</h2>
> > > diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c
> > > b/src/mesa/drivers/dri/i965/brw_disk_cache.c
> > > index f989456bcde..41f742e858f 100644
> > > --- a/src/mesa/drivers/dri/i965/brw_disk_cache.c
> > > +++ b/src/mesa/drivers/dri/i965/brw_disk_cache.c
> > > @@ -407,9 +407,6 @@ void
> > >  brw_disk_cache_init(struct intel_screen *screen)
> > >  {
> > >  #ifdef ENABLE_SHADER_CACHE
> > > -   if (env_var_as_boolean("MESA_GLSL_CACHE_DISABLE", true))
> > > -      return;
> >
> > Should we just flip the default so we still have the environment variable
> > to shut it off if we have problems?
>
> The disk_cache_create function (called later) also looks at the same
> variable, and it defaults to enabling the shader cache.
>
> That's the reason I chose to use this variable name, even though it
> has meant that we had to use a double negative
> (MESA_GLSL_CACHE_DISABLE=0) to allow the i965 disk shader cache to be
> enabled.
>

Fair enough.  I figured it was something like that.  I just wanted to
double-check. :-)

--Jason



> -Jordan
>
> >
> > > -
> > >     char renderer[10];
> > >     MAYBE_UNUSED int len = snprintf(renderer, sizeof(renderer),
> "i965_%04x",
> > >                                     screen->deviceID);
> > > --
> > > 2.15.1
> > >
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180205/7468b68e/attachment.html>