[Mesa-dev] [PATCH] util: remove redundant check for the __clang__ macro

Brian Paul brianp at vmware.com
Mon Feb 5 20:51:06 UTC 2018


On 02/05/2018 01:44 PM, Vlad Golovkin wrote:
> Clang defines __GNUC__ macro, so one doesn't need to check __clang__
> macro in this particular case.

Perhaps mention that in a comment below so there's no confusion.

-Brian

> ---
>   src/util/macros.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/macros.h b/src/util/macros.h
> index 432d513930..d36ca095d5 100644
> --- a/src/util/macros.h
> +++ b/src/util/macros.h
> @@ -138,7 +138,7 @@ do {                       \
>   
>   /* Forced function inlining */
>   #ifndef ALWAYS_INLINE
> -#  if defined(__GNUC__) || defined(__clang__)
> +#  if defined(__GNUC__)
>   #    define ALWAYS_INLINE inline __attribute__((always_inline))
>   #  elif defined(_MSC_VER)
>   #    define ALWAYS_INLINE __forceinline
> 



More information about the mesa-dev mailing list