[Mesa-dev] [PATCH] Haiku: convert to autotools

[Dylan Baker]

Quoting kallisti5 (2018-02-05 14:14:42)
> On 2018-02-05 15:39, Dylan Baker wrote:
> > Quoting kallisti5 (2018-02-05 12:58:30)
> >> On 2017-10-24 11:47, Emil Velikov wrote:
> >> > Hi Jerome,
> >> >
> >> > On 23 October 2017 at 16:58, Jerome Duval <jerome.duval at gmail.com>
> >> > wrote:
> >> >> * configure.ac:
> >> >>   -pthread is not available on Haiku.
> >> >>   Haiku doesn't require --enable-dri
> >> >>   build hgl on Haiku
> >> >> * egl/Makefile.am: define backendfiles for Haiku
> >> >> * src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/hgl and
> >> >> targets/haiku-softpipe on Haiku.
> >> >> * src/gallium/targets/haiku-softpipe: add Makefile.am
> >> >> * src/gallium/state_trackers/hgl: add Makefile.am
> >> >> * winsys/sw/hgl: add Makefile.am
> >> >> * src/hgl/Makefile.am: add Makefile.am
> >> >> ---
> >> > Thanks for the patch. I think Eric has a point regarding splitting this
> >> > up.
> >> > Here is one way to handle it:
> >> >  - patch 1 - the driver, aka st/hgl + sw/hgl + targets/haiku
> >> >  - 2 - src/egl
> >> >  - 3 - src/hgl
> >> >  - 4 misc fixes (the SoftwareRenderer.cpp hunk?)
> >> >  - 5 toggle - configure.ac + src/Makefile.am
> >> 
> >> Hm, it looks like Jerome never got back to work on these changes... 
> >> let
> >> me try to
> >> pick up the ball and run with it.
> >> 
> >> > Couple of small suggestions:
> >> >  - keep all the sources and headers in the sources lists in
> >> > Makefile.sources
> >> >  - how do you guys manage pthreads - please mention that in the commit
> >> > message.
> >> >
> >> > If I'm reading this correctly, you strip out -pthread and there's no
> >> > pthread-stubs on Haiku.
> >> 
> >> Haiku (and BeOS for that matter) has pthread support built into its 
> >> core
> >> libroot.so.
> >> 
> >> No need for -lpthread, all applications can assume its presence. 
> >> Things
> >> that link -lpthread actually fail due to a non-existant libpthread...
> >> *however* as i'm typing this i'm being told we recently implemented a
> >> dummy static libpthread.a to try and appease assumptions about 
> >> -lpthread
> >> existence.... so i'll remove the pthread checks :-)
> >> 
> >>   -- Alex
> > 
> > Hi Alex,
> > 
> > I have a branch for building haiku with meson, when I was trying to 
> > compile
> > neither the scons build nor the autotools build seemed to compile on a 
> > Haiku VM
> > instance (x86_64), that was a few months ago though, so maybe its 
> > fixed.
> > 
> > Our plan is to remove autotools from mesa, probably this year. I'm 
> > thinking if
> > things look pretty good through the 18.0 release cycle I'll probably 
> > propose
> > marking autotools as deprecated for 18.1 and propose removal in 18.2.
> 
> Ah. crap.  I just got autoconfig working :-).  Historically I have only 
> used
> SCons for our builds.  I always preferred the SCons build since 
> autotools always
> ends up looking like spaghetti.  Here is what our current build does:

Sorry, I've meant to get on this a little faster, but the meson conversion has
been a lot more time consuming than I predicted it would be, lol.

> 
> https://github.com/haikuports/haikuports/blob/master/sys-libs/mesa/mesa-17.1.4.recipe#L52

Meson should make that a little simpler, since it has an install target, and we
should be able to make that work for you guys as well.

> 
> It looks like Jerome hacked in a patch for autotools... but i've heard 
> some reports
> of instability with the resulting artifacts.
> 
> > I'm not going to block you guys using autotools or NAK anything, I just 
> > want
> > you to be aware that we're trying to consolidate down to just meson and
> > android.mk files. I can respin the haiku patches and CC you if you're 
> > interested in
> > looking at them.
> 
> If Meson is the future, i'm definitely down helping (or even taking 
> over) that branch
> if it is just incomplete Haiku work.

I think it's pretty close to being ready for review. It's based on a branch to
fix static-glapi with meson that never landed, but I think I have that all
sorted now so I'm going to push that today, and that should make the haiku build
pretty simple (it's just one patch after that I think).

> 
> I'm going to try and do better maintenance on Haiku Mesa in 2018. I've 
> been only around
> minimally in 2017 am a little out of date.
> 
> > You might also want to see if you guys can update your meson, at least 
> > last time
> > I checked it was 0.42, and I fixed the pthreads stuff in 0.43 so that 
> > -pthread
> > and -lpthread are never added by meson.
> 
> I just installed meson on Haiku and we are currently at 0.43.0
> 
Awesome, that makes things a lot easier with meson.

You can have a look at the build in general, I think meson is syntactically
pretty nice, it's like a minimal python or ruby, and the builds are much faster
(that's just because ninja is really smart).

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180205/3ed62acf/attachment.sig>