[Mesa-dev] [PATCH] glxinfo/wglinfo: query/print more GL limits

[Eric Engestrom]

On Wednesday, 2018-02-07 10:23:06 -0700, Brian Paul wrote:
> On 02/07/2018 10:12 AM, Eric Engestrom wrote:
> > On Wednesday, 2018-02-07 08:48:06 -0700, Brian Paul wrote:
> > > Query/print limits for GL 3.0 through GL 4.6, plus
> > > GL_ARB_transform_feedback3.  Also, print the GL extension or GL version
> > > for each set of queries to make it more readable.
> > > ---
> > >   src/xdemos/glinfo_common.c | 127 ++++++++++++++++++++++++++++++++++++++++++++-
> > >   1 file changed, 125 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c
> > > index bd25462..07af989 100644
> > > --- a/src/xdemos/glinfo_common.c
> > > +++ b/src/xdemos/glinfo_common.c
> > > @@ -610,12 +610,127 @@ print_limits(const char *extensions, const char *oglstring, int version,
> > >         { 1, GL_MAX_VERTEX_ATTRIB_RELATIVE_OFFSET, "GL_MAX_VERTEX_ATTRIB_RELATIVE_OFFSET", "GL_ARB_vertex_attrib_binding" },
> > >         { 1, GL_MAX_VERTEX_ATTRIB_BINDINGS, "GL_MAX_VERTEX_ATTRIB_BINDINGS", "GL_ARB_vertex_attrib_binding" },
> > >   #endif
> > > +#if defined(GL_VERSION_3_0)
> > > +      { 1, GL_MAX_TRANSFORM_FEEDBACK_INTERLEAVED_COMPONENTS, "GL_MAX_TRANSFORM_FEEDBACK_INTERLEAVED_COMPONENTS", "3.0" },
> > > +      { 1, GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS, "GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS", "3.0" },
> > > +      { 1, GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_COMPONENTS, "GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_COMPONENTS", "3.0" },
> > > +#endif
> > > +#if defined(GL_VERSION_3_1)
> > > +      { 1, GL_MAX_TEXTURE_BUFFER_SIZE, "GL_MAX_TEXTURE_BUFFER_SIZE", "3.1" },
> > > +      { 1, GL_MAX_RECTANGLE_TEXTURE_SIZE, "GL_MAX_RECTANGLE_TEXTURE_SIZE", "3.1" },
> > > +#endif
> > > +#if defined(GL_VERISON_3_2)
> > 
> > typo
> 
> Thanks.  I'll fix before pushing.  R-b?

I don't know this code at all, but this all looks reasonable :)
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> 
> -Brian