[Mesa-dev] [PATCH 1/2] intel/compiler: Memory fence commit must always be enabled for gen10+

Anuj Phogat anuj.phogat at gmail.com
Wed Feb 7 20:22:14 UTC 2018


On Wed, Feb 7, 2018 at 11:56 AM, Francisco Jerez <currojerez at riseup.net>
wrote:

> Anuj Phogat <anuj.phogat at gmail.com> writes:
>
> > Commit bit in the message descriptor (Bit 13) must be always set
> > to true in CNL+ for memory fence messages. It also fixes a piglit
> > GPU hang on cnl+ in simulation environment.
> > Piglit test: arb_shader_image_load_store-shader-mem-barrier
> > See HSD ES # 1404612949
> >
> > Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> > Cc: mesa-stable at lists.freedesktop.org
> > ---
> >  src/intel/compiler/brw_eu_emit.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/intel/compiler/brw_eu_emit.c
> b/src/intel/compiler/brw_eu_emit.c
> > index c25d8d6eda..1fb9aab51c 100644
> > --- a/src/intel/compiler/brw_eu_emit.c
> > +++ b/src/intel/compiler/brw_eu_emit.c
> > @@ -3275,7 +3275,9 @@ brw_memory_fence(struct brw_codegen *p,
> >                   struct brw_reg dst)
> >  {
> >     const struct gen_device_info *devinfo = p->devinfo;
> > -   const bool commit_enable = devinfo->gen == 7 && !devinfo->is_haswell;
> > +   const bool commit_enable =
> > +      devinfo->gen >= 10 || /* HSD ES # 1404612949 */
> > +      (devinfo->gen == 7 && !devinfo->is_haswell);
>
> A BSpec quote if you have one would be more informative here than the
> HSD ES number, particularly if the reader is not on the Intel VPN.  With
> that change:
>
‚ÄčI tried but couldn't find a BSpec change. I'll try once more.
Does your r-b still apply?

>
> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
>
> >     struct brw_inst *insn;
> >
> >     brw_push_insn_state(p);
> > --
> > 2.13.6
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180207/0139f3a2/attachment.html>


More information about the mesa-dev mailing list